Bug 242071 - [PATCH] net/ceph14: allow build with py36+
Summary: [PATCH] net/ceph14: allow build with py36+
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dima Panov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-19 08:24 UTC by Dima Panov
Modified: 2019-12-06 15:28 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (wjw)

Attachments
Allow py36+ checks (2.66 KB, patch)
2019-11-19 08:24 UTC, Dima Panov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dima Panov freebsd_committer freebsd_triage 2019-11-19 08:24:48 UTC 
Created attachment 209244 [details]
Allow py36+ checks

Ceph14 builds fine with python 3.7/3.8
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-12-06 13:50:59 UTC 
A commit references this bug:

Author: fluffy
Date: Fri Dec  6 13:50:34 UTC 2019
New revision: 519142
URL: https://svnweb.freebsd.org/changeset/ports/519142

Log:
  net/ceph14: allow to build with py36+, indeed.

  No PORTREVISION bump, port was always unable to build for py3[78]

  PR:		242071
  Submitted by:	fluffy
  Approved by:	maintainer (timeout, >2 weeks)

Changes:
  head/net/ceph14/Makefile
  head/net/ceph14/files/patch-cmake_modules_FindPython3Interp.cmake
  head/net/ceph14/files/patch-cmake_modules_FindPython3Libs.cmake
Comment 2 Dima Panov freebsd_committer freebsd_triage 2019-12-06 13:56:23 UTC 
Committed!
Comment 3 Willem Jan Withagen 2019-12-06 14:50:16 UTC 
(In reply to Dima Panov from comment #2)

Sorry, one way or another I completed missed any mails for this bug....
Only today I got the 2 you created.

Thanx, for taking this up

--WjW
Comment 4 Willem Jan Withagen 2019-12-06 14:59:50 UTC 
(In reply to commit-hook from comment #1)

Please note that the ceph developers only test with pythen 2.7 and 3.6.
So taking it to 3.7+ might crash and burn in unpredicted ways.
Comment 5 Dima Panov freebsd_committer freebsd_triage 2019-12-06 15:28:52 UTC 
(In reply to Willem Jan Withagen from comment #4)
Sure. By default ports uses python36, so most users will not affected. 
But anyone who set non-default values already assumed to face some runtime bugs, and this patch allows such users to get own binaries and test them