Bug 242302 - x11/xfce4-dashboard: Update to 0.7.6
Summary: x11/xfce4-dashboard: Update to 0.7.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-xfce (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-29 21:01 UTC by Olivier Duchateau
Modified: 2019-11-30 21:50 UTC (History)
1 user (show)

See Also:
madpilot: maintainer-feedback+

Attachments
Patch to update x11/xfce4-dashboard (6.60 KB, patch)
2019-11-29 21:01 UTC, Olivier Duchateau 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau 2019-11-29 21:01:22 UTC 
Created attachment 209536 [details]
Patch to update x11/xfce4-dashboard

- Update to 0.7.6
- Remove previous patches
- Add new patch, because the 'animations.xml' file are not present in tarball, see my bug report [1].

In fact there are 2 patches, one in Makefile, we remove reference to animations.xml. Another one, which consists to hide toggle button, in order to enable (or disable) animations.

[1] https://bugzilla.xfce.org/show_bug.cgi?id=16230
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2019-11-30 13:01:16 UTC 
Thanks for the patch.

To make sure I understand correctly:

You are completely disabling the animations functionality because it's broken due to the missing animations.xml file?
Comment 2 Olivier Duchateau 2019-11-30 14:24:32 UTC 
(In reply to Guido Falsi from comment #1)

Yes, patch in files/ directory hides widget in preferences window (this property is not easily accessible to end users).
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-11-30 21:49:47 UTC 
A commit references this bug:

Author: madpilot
Date: Sat Nov 30 21:48:48 UTC 2019
New revision: 518731
URL: https://svnweb.freebsd.org/changeset/ports/518731

Log:
  - Update xfce4-dashboard to 0.7.6
  - Remove old patches
  - Add patch to disable animations functionality. It's broken due
    to a missing file in the distribution

  PR:		242302
  Submitted by:	Olivier Duchateau <duchateau.olivier@gmail.com>

Changes:
  head/x11/xfce4-dashboard/Makefile
  head/x11/xfce4-dashboard/distinfo
  head/x11/xfce4-dashboard/files/patch-libxfdashboard_application-database.c
  head/x11/xfce4-dashboard/files/patch-libxfdashboard_applications-menu-model.c
  head/x11/xfce4-dashboard/files/patch-settings_general.c
  head/x11/xfce4-dashboard/pkg-plist
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2019-11-30 21:50:00 UTC 
Committed. Thanks!