Bug 242389 - lang/ocaml: fix build on powerpc64 elfv2
Summary: lang/ocaml: fix build on powerpc64 elfv2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: powerpc Any
: --- Affects Only Me
Assignee: Piotr Kubaj
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-02 21:03 UTC by Piotr Kubaj
Modified: 2019-12-16 12:56 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (michipili)

Attachments
patch (7.64 KB, patch)
2019-12-02 21:03 UTC, Piotr Kubaj 		pkubaj: maintainer-approval? (michipili)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-12-02 21:03:07 UTC 
Created attachment 209630 [details]
patch

LLVM miscompiles ocaml on powerpc64 elfv2:
ld: error: bytecomp/printlambda.ml:23:(.text+0x16): relocation R_PPC64_TOC16_DS out of range: 73024 is not in [-32768, 32767]

Use GCC instead. I tested on amd64 that it compiles successfully.

Add a conditional patch enabled only on powerpc64 elfv2 to use elfv2 abi instead of elfv1.

Add a bunch of other patches to correctly check for abi instead of relying on endianness.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-12-16 12:56:13 UTC 
A commit references this bug:

Author: pkubaj
Date: Mon Dec 16 12:56:08 UTC 2019
New revision: 520254
URL: https://svnweb.freebsd.org/changeset/ports/520254

Log:
  lang/ocaml: fix build on powerpc64 elfv2

  LLVM miscompiles ocaml on powerpc64 elfv2:
  ld: error: bytecomp/printlambda.ml:23:(.text+0x16): relocation R_PPC64_TOC16_DS out of range: 73024 is not in [-32768, 32767]

  Use GCC instead on powerpc64.

  Add a conditional patch enabled only on powerpc64 elfv2 to use elfv2 abi instead of elfv1.

  Add a bunch of other patches to correctly check for abi instead of relying on endianness.

  PR:		242389
  Approved by:	michipili@gmail.com (maintainer)

Changes:
  head/lang/ocaml/Makefile
  head/lang/ocaml/files/extra-patch-asmcomp_power_arch.ml
  head/lang/ocaml/files/patch-asmrun_power.S
  head/lang/ocaml/files/patch-byterun_caml_stack.h
  head/lang/ocaml/files/patch-testsuite_tests_asmcomp_power.S