Bug 242547 - [REVIVE] science/orthanc-dicomweb: Plugin to bring support of the DICOMweb standard into Orthanc
Summary: [REVIVE] science/orthanc-dicomweb: Plugin to bring support of the DICOMweb st...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Guangyuan Yang
URL:
Keywords: patch-ready
Depends on: 242546
Blocks:
  Show dependency tree / graph
 
Reported: 2019-12-10 15:33 UTC by Frank Scholl
Modified: 2021-08-09 08:28 UTC (History)
1 user (show)

See Also:

Attachments
.shar of the orthanc-dicomweb port (6.15 KB, text/plain)
2019-12-10 15:33 UTC, Frank Scholl 		no flags Details
orthanc-dicomweb-1.1_1 (6.45 KB, text/plain)
2020-05-25 06:10 UTC, Frank Scholl 		no flags Details
orthanc-dicomweb-1.2 (5.81 KB, text/plain)
2020-06-24 15:32 UTC, Frank Scholl 		no flags Details
Diff / the latest version of science/orthanc-dicomweb (orthanc-dicomweb-1.2, diff based on r545144) (7.73 KB, patch)
2020-08-17 09:20 UTC, Frank Scholl 		maintainer.freebsd: maintainer-approval+
Details | Diff
orthanc-dicomweb 1.6 (6.87 KB, patch)
2021-05-18 12:48 UTC, Frank Scholl 		maintainer.freebsd: maintainer-approval+
Details | Diff
orthanc-dicomweb 1.6 (6.76 KB, patch)
2021-05-28 17:16 UTC, Frank Scholl 		maintainer.freebsd: maintainer-approval+
Details | Diff
dicomweb-1.6.diff (5.69 KB, patch)
2021-06-06 11:40 UTC, Frank Scholl 		maintainer.freebsd: maintainer-approval+
Details | Diff
orthanc-dicomweb-1.6.diff (6.76 KB, patch)
2021-06-08 19:04 UTC, Frank Scholl 		maintainer.freebsd: maintainer-approval+
Details | Diff
orthanc-dicomweb-1.6.diff (6.79 KB, patch)
2021-06-10 15:37 UTC, Frank Scholl 		maintainer.freebsd: maintainer-approval+
Details | Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Scholl 2019-12-10 15:33:24 UTC 
Created attachment 209832 [details]
.shar of the orthanc-dicomweb port

Port expired on 2018-06-07, fixed and cleaned up the build, updated descriptions, willing to maintain the port from now on.

https://www.freshports.org/science/orthanc-dicomweb
Comment 1 Frank Scholl 2019-12-14 11:05:15 UTC 
This port depends on science/orthanc, which got submitted in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242546.
Comment 2 Frank Scholl 2020-05-25 06:10:08 UTC 
Created attachment 214831 [details]
orthanc-dicomweb-1.1_1

Update to build with orthanc-1.6.1, made portlint happy, builds in poudriere
Comment 3 Frank Scholl 2020-06-24 15:32:01 UTC 
Created attachment 215909 [details]
orthanc-dicomweb-1.2

Update to build with orthanc-1.7.1
Comment 4 Frank Scholl 2020-06-26 07:57:36 UTC 
- this is a resurrection.
- also update MOVED and science/Makefile.
Comment 5 Frank Scholl 2020-08-06 08:59:17 UTC 
This version is tested to work with orthanc-1.7.2 (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242546).
Comment 6 Frank Scholl 2020-08-17 09:20:32 UTC 
Created attachment 217274 [details]
Diff / the latest version of science/orthanc-dicomweb (orthanc-dicomweb-1.2, diff based on r545144)

This diff is based on today's head (r545144), including:

- removed orthanc-dicomweb from MOVED
- added orthanc-dicomweb to science/Makefile
Comment 7 Frank Scholl 2021-05-18 12:48:25 UTC 
Created attachment 225063 [details]
orthanc-dicomweb 1.6

Updated port to work with current science/orthanc.
Comment 8 Frank Scholl 2021-05-28 17:16:40 UTC 
Created attachment 225340 [details]
orthanc-dicomweb 1.6

This port got an update and now uses CMAKE_ON / CMAKE_OFF instead of using CMAKE_ARGS.

Further information:
- portlint is fine.
- Builds in poudriere (testport), tested for 11.4, 12.2 and 13.0
Comment 9 Frank Scholl 2021-06-06 11:40:19 UTC 
Created attachment 225591 [details]
dicomweb-1.6.diff

- DISTVERSION is used instead of PORTVERSION
Comment 10 Frank Scholl 2021-06-08 19:04:24 UTC 
Created attachment 225646 [details]
orthanc-dicomweb-1.6.diff

Just updated the .diff to also contain changes in `MOVED` and `science/Makefile`.
Comment 11 Frank Scholl 2021-06-10 15:37:05 UTC 
Created attachment 225708 [details]
orthanc-dicomweb-1.6.diff

- updated `COMMENT` to align them with the those from other Orthanc plugins
- removed `USE_LDCONFIG` (no shared lib installed)
- added `PLIST_SUB` to use %%PORTVERSION%% in `pkg-plist`
- portlint & portfmt are happy
- poudriere testport successful  on 11.4, 12.2, 13.0
Comment 12 commit-hook freebsd_committer freebsd_triage 2021-08-09 08:27:48 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=27ff93b979893807537870b43d7c376e531d5a0a

commit 27ff93b979893807537870b43d7c376e531d5a0a
Author:     Frank Scholl <maintainer.freebsd@xpoundit.com>
AuthorDate: 2021-08-09 08:26:41 +0000
Commit:     Guangyuan Yang <ygy@FreeBSD.org>
CommitDate: 2021-08-09 08:26:41 +0000

    science/orthanc-dicomweb: Revive port

    Plugin to bring support of the DICOMweb standard into Orthanc.

    PR:             242547
    Reviewed by:    lwhsu

 MOVED                                    |  1 -
 science/Makefile                         |  1 +
 science/orthanc-dicomweb/Makefile (new)  | 62 ++++++++++++++++++++++++++++++++
 science/orthanc-dicomweb/distinfo (new)  | 19 ++++++++++
 science/orthanc-dicomweb/pkg-descr (new) | 12 +++++++
 science/orthanc-dicomweb/pkg-plist (new) |  2 ++
 6 files changed, 96 insertions(+), 1 deletion(-)
Comment 13 Guangyuan Yang freebsd_committer freebsd_triage 2021-08-09 08:28:23 UTC 
Committed with modifications. Thanks!