Created attachment 209965 [details] gcc-plugins.diff AFAICT there is no reason why it should not be on by default and having it on by default unlocks the possibility to properly package and maintain GCC plugins without custom builds of lang/gcc*, e.g., for security/afl++.
Remove needs-qa. QA was always fine.
Thank you. I'll include those changes when updating to the snapshots of lang/gcc10-devel and lang/gcc9-devel from around mid-December, which should both happen this week. Let's let this cook for some two weeks and then consider how to go about lang/gcc9? I'll also respond to the e-mail thread on svn-ports-all@freebsd.org.
A commit references this bug: Author: gerald Date: Fri Dec 27 04:13:58 UTC 2019 New revision: 520964 URL: https://svnweb.freebsd.org/changeset/ports/520964 Log: Update to the 20191215 snapshot of GCC 10.0.0. Enable GCC plugins support by default. [1] PR: 242644 [1] Submitted by: tobik [1] Changes: head/lang/gcc10-devel/Makefile head/lang/gcc10-devel/distinfo
A commit references this bug: Author: gerald Date: Sat Dec 28 08:53:04 UTC 2019 New revision: 521207 URL: https://svnweb.freebsd.org/changeset/ports/521207 Log: Update to the 20191214 snapshot of GCC 9.2.1. Enable GCC plugins support by default. [1] PR: 242644 [1] Submitted by: tobik [1] Changes: head/lang/gcc9-devel/Makefile head/lang/gcc9-devel/distinfo
A commit references this bug: Author: gerald Date: Sat Jan 18 08:45:54 UTC 2020 New revision: 523406 URL: https://svnweb.freebsd.org/changeset/ports/523406 Log: Backport (part of) r521207 | gerald | 2019-12-28 from lang/gcc9-devel: Enable GCC plugins support by default. PR: 242644 Submitted by: tobik Differential Revision: https://reviews.freebsd.org/D22292 Changes: head/lang/gcc9/Makefile
With that we have covered GCC 10 (-devel only for now) and GCC 9 (-devel and release), so have addressed everything, right? Thanks for suggesting this change.
(In reply to Gerald Pfeifer from comment #6) Yes, that should be it AFAIAC. Thanks! I'll turn on the GCC option in afl++ after the next round of package builds.
A commit references this bug: Author: gerald Date: Tue Nov 17 08:49:04 UTC 2020 New revision: 555542 URL: https://svnweb.freebsd.org/changeset/ports/555542 Log: Update to the 20201113 snapshot of GCC 9.3.1. This brings two backports for the x86 back end, two for the Fortran front end, and one for libstdc++. Fold the PLUGINS option, which has been on by default, into standard behavior and remove that option. It has not been causing any issues since we enabled it 11 months ago, nor measurable overhead. [1] PR: 242644 [1] Changes: head/lang/gcc9-devel/Makefile head/lang/gcc9-devel/distinfo
A commit references this bug: Author: gerald Date: Wed Nov 18 20:29:58 UTC 2020 New revision: 555665 URL: https://svnweb.freebsd.org/changeset/ports/555665 Log: Update to the 20201114 snapshot of GCC 10.2.1. This brings two backports for GOMP, one for aarch64, two for powerpc (nee rs6000) and two for x86, one for the tree optimizers, two for the C front end and three for C++ and Fortran each, plus half a dozen for libstdc++. Forward port part of r555542 | gerald | 2020-11-17 from lang/gcc9-devel: Fold the PLUGINS option, which has been on by default, into standard behavior and remove that option. It has not been causing any issues since we enabled it 11 months ago, nor measurable overhead. [1] PR: 242644 [1] Changes: head/lang/gcc10-devel/Makefile head/lang/gcc10-devel/distinfo
A commit references this bug: Author: gerald Date: Fri Nov 20 19:53:49 UTC 2020 New revision: 555778 URL: https://svnweb.freebsd.org/changeset/ports/555778 Log: Update to the 20201115 snapshot of GCC 11.0.0. Forward port part of r555542 | gerald | 2020-11-17 from lang/gcc9-devel: Fold the PLUGINS option, which has been on by default, into standard behavior and remove that option. It has not been causing any issues since we enabled it 11 months ago, nor measurable overhead. [1] PR: 242644 [1] Changes: head/lang/gcc11-devel/Makefile head/lang/gcc11-devel/distinfo
A commit references this bug: Author: gerald Date: Sat Nov 28 10:45:21 UTC 2020 New revision: 556486 URL: https://svnweb.freebsd.org/changeset/ports/556486 Log: Back port part of r555665 | gerald | 2020-11-18 from lang/gcc10-devel: Forward port part of r555542 | gerald | 2020-11-17 from lang/gcc9-devel: Fold the PLUGINS option, which has been on by default, into standard behavior and remove that option. It has not been causing any issues since we enabled it 11 months ago, nor measurable overhead. PR: 242644 Changes: head/lang/gcc10/Makefile
A commit references this bug: Author: gerald Date: Thu Dec 17 09:52:10 UTC 2020 New revision: 558274 URL: https://svnweb.freebsd.org/changeset/ports/558274 Log: Back port part of r555542 | gerald | 2020-11-17 from lang/gcc9-devel: Fold the PLUGINS option, which has been on by default, into standard behavior and remove that option. It has not been causing any issues since we enabled it 11 months ago, nor measurable overhead. PR: 242644 Changes: head/lang/gcc9/Makefile
With the last commit, I believe this topic can be fully closed: plugins are now enabled in all recent versions of GCC, not just via an option (if on by default), but simply enabled.