Bug 242793 - www/phalcon4: update to final 4.0.0
Summary: www/phalcon4: update to final 4.0.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-22 08:23 UTC by Franco Fichtner
Modified: 2019-12-23 05:45 UTC (History)
2 users (show)

See Also:

Attachments
4.0.0 update (1.45 KB, patch)
2019-12-22 08:23 UTC, Franco Fichtner 		franco: maintainer-approval+
Details | Diff
second revision (1.63 KB, patch)
2019-12-22 16:36 UTC, Franco Fichtner 		franco: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Franco Fichtner 2019-12-22 08:23:49 UTC 
Created attachment 210129 [details]
4.0.0 update

Hi,

Phalcon 4.0.0 was released yesterday:

https://github.com/phalcon/cphalcon/releases/tag/v4.0.0

PHP 7.4 should be back to working order and this patch also adds the proper conflict to www/phalcon as both write a phalcon.so file.


Cheers,
Franco
Comment 1 ruud 2019-12-22 08:32:57 UTC 
Thnx Franco!
Comment 2 Tobias C. Berner freebsd_committer freebsd_triage 2019-12-22 12:38:47 UTC 
[00:00:44] [06] [00:00:25] Finished www/phalcon4@php74 | php74-phalcon4-4.0.0: Failed: build

seems still to be broken with php74.


mfg Tobias
Comment 3 Franco Fichtner 2019-12-22 16:36:59 UTC 
Created attachment 210146 [details]
second revision

@Ruud, seems to be this issue still:

https://www.mail-archive.com/freebsd-pkg-fallout@freebsd.org/msg1264145.html

Using -Dulong=zend_ulong fixes this in Zephir code.  Let's use this unconditionally in all PHP versions until an upstream fix exists.

New patch attached.  Thanks for the quick test Tobias.


Cheers,
Franco
Comment 4 ruud 2019-12-22 16:49:46 UTC 
Ok,

I will check with Serghei about this issue.
One thing I noticed is some cphalcon-3.4.4 directories. I assume this is just a directory. Or is there something mixed?

thnx.
Ruud
Comment 5 Franco Fichtner 2019-12-22 17:02:32 UTC 
This was a log of a 3.4.4 build failure on PHP 7.4 indeed. But 4.0.0 had the same complaint so I posted the one that was already on the web.


Cheers,
Franco
Comment 6 Tobias C. Berner freebsd_committer freebsd_triage 2019-12-22 20:17:02 UTC 
Committed. Thanks.
Comment 7 commit-hook freebsd_committer freebsd_triage 2019-12-22 20:17:04 UTC 
A commit references this bug:

Author: tcberner
Date: Sun Dec 22 20:16:55 UTC 2019
New revision: 520659
URL: https://svnweb.freebsd.org/changeset/ports/520659

Log:
  www/phalcon4: update to final 4.0.0

  Changelog:
  https://github.com/phalcon/cphalcon/releases/tag/v4.0.0

  Additionally:
  - fix build with PHP 7.4
  - add conflict to www/phalcon

  PR:		242793
  Submitted by:	Franco Fichtner <franco@opnsense.org> (maintainer)

Changes:
  head/www/phalcon/Makefile
  head/www/phalcon4/Makefile
  head/www/phalcon4/distinfo
Comment 8 Franco Fichtner 2019-12-23 05:45:30 UTC 
Awesome, thanks!