emulators/wine works just fine, but if I disable X11 support in wine-devel, I get the following error when running "make install clean": ===> wine-devel-5.0.r1,1 need to specify xorg modules with USE_XORG. *** Error code 1 Stop. make: stopped in /usr/ports/emulators/wine-devel
Thanks for letting us know! I believe I know what's going on (and why you only see this for wine-devel and not the production wine port). If I am right, this should not be specific to Wine 5.0 RC1, though. Do you believe it worked for earlier snapshots and it worked or is this a fresh attempt?
Created attachment 210347 [details] Proposed patch (akin to what we arrived at for emulators/wine in two steps) Does this patch address the issue you've been seeing? (I'm still interested in the answers to my questions from earlier today, just wanted to give it a try and get you unstuck quickly if possible.)
I only recently found a use for wine without X11 support, so this is my first time trying to build it with X11 disabled. So it's possible this has been an undiscovered bug for some time. In any case, the proposed patch allowed wine-devel to configure, build, and install successfully with X11 disabled. Thanks for your quick response!
A commit references this bug: Author: gerald Date: Thu Jan 2 06:01:57 UTC 2020 New revision: 521798 URL: https://svnweb.freebsd.org/changeset/ports/521798 Log: Make sure we employ USES=xorg only when X11/Xorg are actually used, much as we have had this for USE_XORG and USE_GL for a while. Without this building with option X11 off actually fails now due to increased checks in the FreeBSD ports infrastructure. PR: 242996 Reported by: Patrick McMunn <doctorwhoguy@gmail.com> Changes: head/emulators/wine-devel/Makefile
Thanks for the report and the follow-ups. Per your confirmation of the proposed patch this should be fixed with what I just committed, so I am closing this report as such. Please advise if I missed something and I'll swiftly look into it.
Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=770f3a4edf68e545f9f19b2c5fc3fff58021cc40 commit 770f3a4edf68e545f9f19b2c5fc3fff58021cc40 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2023-06-26 20:28:52 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2023-06-26 20:28:58 +0000 devel/util-linux: Unbreak on FreeBSD 13.2 and set pkgconfigdir * Remove bswap compatibility "hacks" as we now have glibc compatible ones in supported releases * Set pkgconfigdir so .pc files ends up in correct path PR: 242996 Reviewed by: Warner Losh <imp@bsdimp.com>, yuri (maintainer) devel/util-linux/Makefile | 6 ++-- devel/util-linux/files/patch-include_bitops.h | 47 +++++---------------------- 2 files changed, 12 insertions(+), 41 deletions(-)