Bug 243478 - [NEW PORT] x11-themes/gartoon-redux: A collection of icons for GNOME
Summary: [NEW PORT] x11-themes/gartoon-redux: A collection of icons for GNOME
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-21 01:43 UTC by Jonathan Chen
Modified: 2020-02-10 18:28 UTC (History)
2 users (show)

See Also:

Attachments
shar archive for x11-themes/gartoon-redux (856.47 KB, text/plain)
2020-01-21 01:43 UTC, Jonathan Chen 		no flags Details
gartoon-redux shar archive (856.47 KB, text/plain)
2020-02-02 18:54 UTC, Jonathan Chen 		no flags Details
gartoon-redux shar (856.38 KB, text/plain)
2020-02-05 20:59 UTC, Jonathan Chen 		no flags Details
New patch. Port renamed (858.00 KB, patch)
2020-02-09 21:51 UTC, Fernando Apesteguía 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Chen 2020-01-21 01:43:26 UTC 
Created attachment 210906 [details]
shar archive for x11-themes/gartoon-redux

A Collection of Icons for GNOME.
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2020-02-02 11:44:39 UTC 
portlint -AC complains a lot:

FATAL: Makefile: extra item "MASTER_SITES" placed in the MAINTAINER section.
WARN: Makefile: COMMENT is set externally to this port's Makefile, but this port is not configured as a slave port.
FATAL: Makefile: extra item "MAINTAINER" placed in the LICENSE section.
FATAL: Makefile: extra item "COMMENT" placed in the LICENSE section.
WARN: Makefile: "LICENSE_FILE" has to appear earlier.
WARN: Makefile: "LICENSE_FILE" has to appear earlier.
WARN: Makefile: "LICENSE" has to appear earlier.
WARN: Makefile: "LICENSE_FILE" has to appear earlier.
WARN: Makefile: "BUILD_DEPENDS" has to appear earlier.
WARN: Makefile: "USES" has to appear earlier.
WARN: /home/pi/m/x11-themes/gartoon-redux/files/patch-configure: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
WARN: /home/pi/m/x11-themes/gartoon-redux/files/patch-links.pl: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
Comment 2 Jonathan Chen 2020-02-02 18:54:45 UTC 
Created attachment 211291 [details]
gartoon-redux shar archive

Removed empty-line before MAINTAINER=
Comment 3 Jonathan Chen 2020-02-05 20:59:33 UTC 
Created attachment 211389 [details]
gartoon-redux shar

Cleared last of portlint warnings.
Comment 4 Jonathan Chen 2020-02-09 18:08:52 UTC 
Hi, is anything holding up this commit? What else do I need to do?
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2020-02-09 18:27:54 UTC 
(In reply to Jonathan Chen from comment #4)

It's fine. I'm testing it. I'm hooking it up to x11-themes/gnome-icons too.
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2020-02-09 21:51:54 UTC 
Created attachment 211522 [details]
New patch. Port renamed

Added new patch.

- Rename port to gnome-icons-gartoon-redux as in similar ports
- Add gnome category
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2020-02-09 21:52:23 UTC 
Hi Johnathan,

Would you mind having a look at the new patch?

Cheers!
Comment 8 Jonathan Chen 2020-02-09 22:02:13 UTC 
Looks good
Comment 9 commit-hook freebsd_committer freebsd_triage 2020-02-10 18:27:27 UTC 
A commit references this bug:

Author: fernape
Date: Mon Feb 10 18:26:55 UTC 2020
New revision: 525728
URL: https://svnweb.freebsd.org/changeset/ports/525728

Log:
  new port: x11-themes/gnome-icons-gartoon-redux

  Improved variant of the well-known Gartoon theme for Gnome and Mate desktops.

  PR:     243478
  Submitted by:   jonc@chen.org.nz

Changes:
  head/x11-themes/Makefile
  head/x11-themes/gnome-icons/Makefile
  head/x11-themes/gnome-icons-gartoon-redux/
  head/x11-themes/gnome-icons-gartoon-redux/Makefile
  head/x11-themes/gnome-icons-gartoon-redux/distinfo
  head/x11-themes/gnome-icons-gartoon-redux/files/
  head/x11-themes/gnome-icons-gartoon-redux/files/patch-configure
  head/x11-themes/gnome-icons-gartoon-redux/files/patch-install-links.pl
  head/x11-themes/gnome-icons-gartoon-redux/pkg-descr
  head/x11-themes/gnome-icons-gartoon-redux/pkg-plist
Comment 10 Fernando Apesteguía freebsd_committer freebsd_triage 2020-02-10 18:28:27 UTC 
Landed.

Thanks for your patience!