Created attachment 211199 [details] svn(1) diff against the ports tree This patch includes unwinding of SSP_CFLAGS for devel/glib20, emulators/qemu-sbruno, emulators/qemu-user-static-devel -- the latter two are "Approved by: emulation (maintainer, kevans)" - devel/glib20 SSP_CFLAGS were added in r500819. - emulators/qemu-sbruno SSP_CFLAGS were added in r501032. Both of these were added to workaround what turned out to be imprecise ordering in libc, which is now fixed in all supported releases as of 11.3-p6, 12.0-p13, 12.1-p2. This patch may need to be delayed slightly to make sure the package builders have caught up to the appropriate patchlevel to ensure we don't end up with broken packages, but I'm told this happens frequently. Anyone building their own ports will need to ensure they're building against a base of the appropriate patchlevels.
This patch in-fact does not need to be delayed- I have confirmed from the 12.0/11.3 builders' logs that they are at the latest patch levels for this.
Comment on attachment 211199 [details] svn(1) diff against the ports tree Approved by: kwm (gnome, maintainer via IRC) [1]
Comment on attachment 211199 [details] svn(1) diff against the ports tree Approved by: koobs (ports, for emulators/qemu*) [2]
A commit references this bug: Author: kevans Date: Wed Feb 5 16:06:32 UTC 2020 New revision: 525281 URL: https://svnweb.freebsd.org/changeset/ports/525281 Log: glib20: revert SSP_CFLAGS workaround (ports r500819) This was later diagnosed to be a bug in libc, which has since been addressed in all supported releases and branches. PORTREVISION is bumped as SSP_CFLAGS will change the output. The bug was fixed in the following patch levels (FreeBSD-EN-20:01.ssp): - 12.1-p2 - 12.0-p13 - 11.3-p6 PR: 243735 Approved by: kwm (gnome, maintainer via IRC) MFH: 2020Q1 Changes: head/devel/glib20/Makefile
A commit references this bug: Author: kevans Date: Wed Feb 5 16:09:20 UTC 2020 New revision: 525282 URL: https://svnweb.freebsd.org/changeset/ports/525282 Log: qemu-user-static: revert SSP_CFLAGS workaround (ports r501032) This was later diagnosed to be a bug in libc, which has since been addressed in all supported releases and branches. PORTREVISION is bumped as SSP_CFLAGS will change the output, and for consumers of these two ports it is imperative that it be rebuilt against the updated libc to avoid high failure rates. In testing qemu-user-static-devel failed roughly 60% of the time, rendering it unusable as each fork/exec was yet one more chance to fail. The bug was fixed in the following patch levels (FreeBSD-EN-20:01.ssp): - 12.1-p2 - 12.0-p13 - 11.3-p6 PR: 243735 Approved by: koobs (ports) MFH: 2020Q1 Changes: head/emulators/qemu-sbruno/Makefile head/emulators/qemu-user-static-devel/Makefile
Committed; thanks! I intend to MFH both of these to 2020Q1, since the relevant quarterly packages are effectively broken at runtime in a way that consumers can't do anything about.
A commit references this bug: Author: kevans Date: Thu Feb 20 19:02:20 UTC 2020 New revision: 526581 URL: https://svnweb.freebsd.org/changeset/ports/526581 Log: MFH: r525281 glib20: revert SSP_CFLAGS workaround (ports r500819) This was later diagnosed to be a bug in libc, which has since been addressed in all supported releases and branches. PORTREVISION is bumped as SSP_CFLAGS will change the output. The bug was fixed in the following patch levels (FreeBSD-EN-20:01.ssp): - 12.1-p2 - 12.0-p13 - 11.3-p6 PR: 243735 Approved by: kwm (gnome, maintainer via IRC) Approved by: ports-secteam (miwi) Changes: _U branches/2020Q1/ branches/2020Q1/devel/glib20/Makefile
A commit references this bug: Author: kevans Date: Thu Feb 20 19:05:03 UTC 2020 New revision: 526582 URL: https://svnweb.freebsd.org/changeset/ports/526582 Log: MFH: r525282 qemu-user-static: revert SSP_CFLAGS workaround (ports r501032) This was later diagnosed to be a bug in libc, which has since been addressed in all supported releases and branches. PORTREVISION is bumped as SSP_CFLAGS will change the output, and for consumers of these two ports it is imperative that it be rebuilt against the updated libc to avoid high failure rates. In testing qemu-user-static-devel failed roughly 60% of the time, rendering it unusable as each fork/exec was yet one more chance to fail. The bug was fixed in the following patch levels (FreeBSD-EN-20:01.ssp): - 12.1-p2 - 12.0-p13 - 11.3-p6 PR: 243735 Approved by: koobs (ports) Approved by: ports-secteam (implicit, runtime fix) Changes: _U branches/2020Q1/ branches/2020Q1/emulators/qemu-sbruno/Makefile branches/2020Q1/emulators/qemu-user-static-devel/Makefile