Bug 243944 - net/pacemaker1: allow using base ncurses
Summary: net/pacemaker1: allow using base ncurses
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Vinícius Zavam
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2020-02-06 20:35 UTC by Steve Wills
Modified: 2020-02-07 17:26 UTC (History)
1 user (show)

See Also:
egypcio: maintainer-feedback+

Attachments
proposed patch (485 bytes, patch)
2020-02-06 20:35 UTC, Steve Wills 		swills: maintainer-approval? (egypcio)
 Details | Diff
[PATCH] net/pacemaker1: use base's ncurses, build against python37, un-deprecate (9.04 KB, patch)
2020-02-07 14:27 UTC, Vinícius Zavam 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Wills freebsd_committer freebsd_triage 2020-02-06 20:35:23 UTC 
Created attachment 211430 [details]
proposed patch
Comment 1 Vinícius Zavam freebsd_committer freebsd_triage 2020-02-07 14:27:14 UTC 
Created attachment 211446 [details]
[PATCH] net/pacemaker1: use base's ncurses, build against python37, un-deprecate

hi,
can you also test this patch?

  - un-deprecate the port;
  - supports python36 and python37;
  - patch md5sum calls, using `md5` from base system;
Comment 2 Vinícius Zavam freebsd_committer freebsd_triage 2020-02-07 14:29:34 UTC 
I am thinking about applying the 2 new patches only if `${PYTHON_SUFFIX} > 36`
Comment 3 Steve Wills freebsd_committer freebsd_triage 2020-02-07 14:41:47 UTC 
(In reply to Vinícius Zavam from comment #2)
That all seems fine to me.
Comment 4 Vinícius Zavam freebsd_committer freebsd_triage 2020-02-07 16:43:33 UTC 
(In reply to Steve Wills from comment #3)

cool stuff thou; thanks!
as this also affects pacemaker2, this PR will be reference at 2 commits.
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-02-07 17:24:45 UTC 
A commit references this bug:

Author: egypcio
Date: Fri Feb  7 17:23:51 UTC 2020
New revision: 525492
URL: https://svnweb.freebsd.org/changeset/ports/525492

Log:
  net/pacemaker1: base ncurses, py37- support, and un-deprecate it

    Makefiles
      - un-deprecate the port; bump PORTREVISION;
      - apply certain patches only if PYTHON_SUFFIX > 36;
      - use base system's ncurses instead of ports';

    pkg-plist: use %%PYTHON_SUFFIX%%, instead of its value

    files/*
      - extra*.py: https://docs.python.org/3/whatsnew/3.7.html
      - patch-tools_cibsecret.in: make proper use of `md5`

  PR:		243944
  Submitted by:	swills

Changes:
  head/net/pacemaker1/Makefile
  head/net/pacemaker1/Makefile.common
  head/net/pacemaker1/files/extra-patch-cts_remote.py
  head/net/pacemaker1/files/extra-patch-cts_watcher.py
  head/net/pacemaker1/files/patch-tools_cibsecret.in
  head/net/pacemaker1/pkg-plist
Comment 6 commit-hook freebsd_committer freebsd_triage 2020-02-07 17:25:46 UTC 
A commit references this bug:

Author: egypcio
Date: Fri Feb  7 17:25:40 UTC 2020
New revision: 525493
URL: https://svnweb.freebsd.org/changeset/ports/525493

Log:
  net/pacemaker2: base ncurses, py37- support, and un-deprecate it

    follow ports@r525492.

  PR:		243944
  Submitted by:	swills

Changes:
  head/net/pacemaker2/Makefile
  head/net/pacemaker2/files/patch-tools_cibsecret.in
  head/net/pacemaker2/pkg-plist
Comment 7 Vinícius Zavam freebsd_committer freebsd_triage 2020-02-07 17:26:46 UTC 
fixed. thanks !