Created attachment 211837 [details] [patch] don't define RUN_DEPENDS based on BUILD_DEPENDS The porter's handbook advises that RUN_DEPENDS should be defined based on BUILD_DEPENDS. https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-depend.html#makefile-run_depends portlint noticed the problem: FATAL: Makefile: RUN_DEPENDS should not be set to ${BUILD_DEPENDS} as ${BUILD_DEPENDS} includes other implicit dependencies. Instead, copy the explicit dependencies from BUILD_DEPENDS to RUN_DEPENDS. See http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-depend.html#AEN2154 for more details. It's probably okay to include this fix with a later change. There is a chance that some change to Uses/python.mk causes additional BUILD_DEPENDS that would then propagate to RUN_DEPENDS, thus changing the package. But the likelihood of such a change seems low. So this change can wait to be included with another future change (e.g., PORTVERSION update).
(In reply to John Hein from comment #0) Oops... s|should be defined|should not be defined|
A commit references this bug: Author: mfechner Date: Sat Feb 29 14:18:31 UTC 2020 New revision: 527420 URL: https://svnweb.freebsd.org/changeset/ports/527420 Log: Cosmetic change for the dependency definition. There is no change in the definition, so no port bump. This should prevent later problems if the BUILD_DEPENDS or RUN_DEPENDS is modified by USE definitions. PR: 244314 Submitted by: jcfyecrayz@liamekaens.com Changes: head/devel/py-pygit2/Makefile
Committed, thanks.