Bug 244355 - textproc/ripgrep: don't install completion file for fish
Summary: textproc/ripgrep: don't install completion file for fish
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Mateusz Piotrowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-24 00:40 UTC by Alan Somers
Modified: 2020-02-24 13:34 UTC (History)
2 users (show)

See Also:
petteri.valkonen: maintainer-feedback+

Attachments
Don't install rg.fish (1.00 KB, patch)
2020-02-24 00:40 UTC, Alan Somers 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Somers freebsd_committer freebsd_triage 2020-02-24 00:40:34 UTC 
Created attachment 211877 [details]
Don't install rg.fish

ripgrep tries to install a completion file for the fish shell.  But the next version of shells/fish includes that file, creating a conflict.  The best way to resolve the conflict is to let fish manage the file itself.
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-02-24 13:03:06 UTC 
A commit references this bug:

Author: 0mp
Date: Mon Feb 24 13:02:10 UTC 2020
New revision: 526967
URL: https://svnweb.freebsd.org/changeset/ports/526967

Log:
  Don't install completion file for fish

  ripgrep tries to install a completion file for the fish shell.
  But the next version of shells/fish includes that file, creating
  a conflict.  The best way to resolve the conflict is to let fish
  manage the file itself.

  PR:		244355
  Submitted by:	asomers
  Approved by:	Petteri Valkonen (maintainer)

Changes:
  head/textproc/ripgrep/Makefile
Comment 2 Mateusz Piotrowski freebsd_committer freebsd_triage 2020-02-24 13:34:20 UTC 
Committed! Thanks!