Bug 244507 - devel/dee: Fix build with clang 10.0.0
Summary: devel/dee: Fix build with clang 10.0.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jung-uk Kim
URL:
Keywords:
Depends on:
Blocks: 244251
  Show dependency tree / graph
 
Reported: 2020-02-28 19:30 UTC by Dimitry Andric
Modified: 2020-03-19 07:04 UTC (History)
1 user (show)

See Also:

Attachments
Fix devel/dee build with clang 10.0.0 (1.15 KB, patch)
2020-02-28 19:30 UTC, Dimitry Andric 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2020-02-28 19:30:04 UTC 
Created attachment 212031 [details]
Fix devel/dee build with clang 10.0.0

As reported in bug 244251, with clang 10.0.0 the devel/dee port fails to build with:

dee-serializable-model.c:1331:5: error: misleading indentation; statement is not part of the previous 'while' [-Werror,-Wmisleading-indentation]
    pos++;
    ^
dee-serializable-model.c:1329:3: note: previous statement is here
  while (!dee_model_is_last (self, iter) && iter != _iter)
  ^

This is a known upstream bug (https://bugs.launchpad.net/dee/+bug/1579529), but as it has been reported 4 years ago and still not fixed, here is a patch.
Comment 1 Jung-uk Kim freebsd_committer freebsd_triage 2020-03-19 06:48:21 UTC 
I committed the upstream patch without knowing this PR.  Sorry.
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-03-19 07:04:11 UTC 
A commit references this bug:

Author: jkim
Date: Thu Mar 19 07:03:33 UTC 2020
New revision: 528689
URL: https://svnweb.freebsd.org/changeset/ports/528689

Log:
  Utilize USES=localbase.

  Note the previous commit actually fixed the following PR.

  PR:		244507

Changes:
  head/devel/dee/Makefile