Bug 244651 - net-im/telegram-desktop: update to 1.9.14
Summary: net-im/telegram-desktop: update to 1.9.14
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL:
Keywords:
Depends on: 244550 244552
Blocks:
  Show dependency treegraph
 
Reported: 2020-03-07 02:39 UTC by Henry Hu
Modified: 2020-03-15 08:13 UTC (History)
1 user (show)

See Also:


Attachments
patch for 1.9.14 (86.88 KB, patch)
2020-03-07 02:39 UTC, Henry Hu
henry.hu.sh: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Henry Hu 2020-03-07 02:39:01 UTC
Created attachment 212213 [details]
patch for 1.9.14

Update telegram-desktop to 1.9.14.

This is a huge change, because
1. telegram-desktop gets rid of gyp. It moved to cmake completely.
2. It becomes more friendly to distros. Previously its default compilation method will download everything's source into its directory and compile a static binary linking everything inside. Now it is very easy to link with libraries already installed in the system.
3. It now provides a "full" source package, which includes all the dependencies. As a result, we no longer need to fetch each dependency individually.
4. Some internal libraries/utilities are extracted to a separate account, "desktop-app". We may consider add BSD support to these libraries directly.

As a result
1. Lots of patches are no longer needed, as they are already merged, or they no longer apply.
2. Now most patches are changing
#ifdef Q_OS_LINUX
to
#if defined Q_OS_LINUX || defined Q_OS_FREEBSD
3. GH_TUPLE is not needed anymore.

Arch's using the TEST API option. I think that it would be better to actually register an API key for the FreeBSD version, so I registered one.

We may extract more dependencies and package them separately in the future. Currently, rlottie, variant, and libtgvoip are still bundled.

This PR depends on pr/244550 and pr/244552. These must be submitted first.
Comment 2 Tobias C. Berner freebsd_committer freebsd_triage 2020-03-15 08:13:32 UTC
Committed. Thanks.
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-03-15 08:13:57 UTC
A commit references this bug:

Author: tcberner
Date: Sun Mar 15 08:12:58 UTC 2020
New revision: 528475
URL: https://svnweb.freebsd.org/changeset/ports/528475

Log:
  net-im/telegram-desktop: update to 1.9.14

  PR:		244651
  Submitted by:	Henry Hu <henry.hu.sh@gmail.com> (maintainer)

Changes:
  head/net-im/telegram-desktop/Makefile
  head/net-im/telegram-desktop/distinfo
  head/net-im/telegram-desktop/files/CMakeLists.inj
  head/net-im/telegram-desktop/files/gyp-patches
  head/net-im/telegram-desktop/files/patch-Telegram_CMakeLists.txt
  head/net-im/telegram-desktop/files/patch-Telegram_Resources_qrc_linux.qrc
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_base_build__config.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_base_bytes.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_core_launcher.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_core_update__checker.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_data_data__document.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_export_data_export__data__types.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_history_admin__log_history__admin__log__inner.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_history_history__inner__widget.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_history_view_history__view__list__widget.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_logs.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_freebsd_info__freebsd.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_freebsd_info__freebsd.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_linux_linux__libs.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_linux_linux__libs.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_linux_main__window__linux.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_platform_platform__info.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_qt__functions.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_qt__static__plugins.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_settings_settings__notifications.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_storage_storage__encrypted__file__tests.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_ui_platform_ui__platform__utility.h
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_ui_text_text.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_ui_widgets_labels.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_SourceFiles_window_main__window.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_VoIPController.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_libtgvoip_os_linux_AudioPulse.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_gyp_PrecompiledHeader.cmake
  head/net-im/telegram-desktop/files/patch-Telegram_gyp_common_common.gypi
  head/net-im/telegram-desktop/files/patch-Telegram_gyp_telegram_sources.txt
  head/net-im/telegram-desktop/files/patch-Telegram_lib__base_base_bytes.h
  head/net-im/telegram-desktop/files/patch-Telegram_lib__base_base_platform_base__platform__file__utilities.h
  head/net-im/telegram-desktop/files/patch-Telegram_lib__base_base_platform_base__platform__info.h
  head/net-im/telegram-desktop/files/patch-Telegram_lib__base_base_zlib__help.h
  head/net-im/telegram-desktop/files/patch-Telegram_lib__ui_ui_platform_ui__platform__utility.h
  head/net-im/telegram-desktop/files/patch-Telegram_lib__ui_ui_style_style__core__font.cpp
  head/net-im/telegram-desktop/files/patch-Telegram_lib__ui_ui_widgets_labels.cpp
  head/net-im/telegram-desktop/files/patch-cmake_external_opus_CMakeLists.txt
  head/net-im/telegram-desktop/files/patch-cmake_external_qt_CMakeLists.txt
  head/net-im/telegram-desktop/files/patch-lib_xdg_tg.protocol
  head/net-im/telegram-desktop/pkg-plist