Created attachment 212417 [details] Patch for LAME Compile and run-time tested on FreeBSD 13.0-CURRENT #0 r358620 (AMD64) Poudriere OK 12.1-RELEASE
Alexander, can you have a look at this?
swills@ Something you can have a look at this? You committed my previous PRs regarding this that reached maintainer timeout.
Hi, I can tell you that upstream (and I am part of upstream), this is only tested with gmake. I have no hardware to test the 32bit case (with nasm). The important part here is that all is handled by automake, except the nasm part, which contains a little hack which goes beyond what automake is normally doing. So testing this part is the important part here. Apart from that, what is your goal with this patch? Yes, reducing dependencies is nice, but this is just a build time dependency, and gmake is a very common dependency of various ports. The "cost" of this dependency is in my opinion (YMMV) very small, specially on the amd64 platform. Bye, Alexander.
Hi, Yes, the main goal is to remove the gmake dependency. While I agree that it's not a large dependency there is interest in not using GNU tools if possible for compilation. Many "common" ports already doesn't require it so having it defined just for the sake of it seems unnecessary. I gave this a go on 11.3-RELEASE i386, it runs and compiles and runs fine in a VM. Best regards, Daniel
A commit references this bug: Author: netchild Date: Mon May 4 08:36:16 UTC 2020 New revision: 533904 URL: https://svnweb.freebsd.org/changeset/ports/533904 Log: Remove build-dependency on gmake. PR: 244815 Submitted by: daniel.engberg.lists@pyret.net Tested by: daniel.engberg.lists@pyret.net (i386 for nasm-hacks) Changes: head/audio/lame/Makefile