Bug 244861 - sysutils/rsfetch: memory reporting broken
Summary: sysutils/rsfetch: memory reporting broken
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-17 14:41 UTC by Mikael Urankar
Modified: 2020-03-18 08:38 UTC (History)
1 user (show)

See Also:
lcook: maintainer-feedback+

Attachments
patch (3.24 KB, patch)
2020-03-17 14:41 UTC, Mikael Urankar 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer freebsd_triage 2020-03-17 14:41:39 UTC 
Created attachment 212461 [details]
patch

rsfetch -r
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: ParseFloatError { kind: Invalid }', src/memory.rs:82:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

it's fixed upstream:
https://github.com/rsfetch/rsfetch/pull/79

with the attached patch:
rsfetch -r

■──────────────────────────────────■
│ MEMORY   =   37.88GiB / 63.91GiB │
■──────────────────────────────────■
Comment 1 Lewis Cook freebsd_committer freebsd_triage 2020-03-17 22:13:26 UTC 
Thanks, didn't catch this. :)
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-03-18 08:35:34 UTC 
A commit references this bug:

Author: mikael
Date: Wed Mar 18 08:34:37 UTC 2020
New revision: 528635
URL: https://svnweb.freebsd.org/changeset/ports/528635

Log:
  sysutils/rsfetch: fix memory reporting and add DragonFlyBSD support

  Import upstream fix [1] to fix fix memory reporting and add DragonFlyBSD support.

  [1] https://github.com/rsfetch/rsfetch/commit/2bd3ef9eaf1a0369f115022f8acb650682a1bf3e

  PR:		244861
  Approved by:	Lewis Cook (maintainer), manu (mentor, implicit)

Changes:
  head/sysutils/rsfetch/Makefile
  head/sysutils/rsfetch/files/
  head/sysutils/rsfetch/files/patch-src_memory.rs
  head/sysutils/rsfetch/files/patch-src_util.rs