Bug 245095 - security/tinc-devel: Missing RC status command support
Summary: security/tinc-devel: Missing RC status command support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dirk Meyer
URL:
Keywords: feature, needs-qa
Depends on:
Blocks:
 
Reported: 2020-03-27 10:11 UTC by gerrit
Modified: 2020-03-27 16:05 UTC (History)
0 users

See Also:
dinoex: maintainer-feedback+
dinoex: merge-quarterly-

Attachments
add status support to service (663 bytes, patch)
2020-03-27 10:11 UTC, gerrit 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description gerrit 2020-03-27 10:11:54 UTC 
Created attachment 212748 [details]
add status support to service

When tincd nets are configured, service status does not work:

root@f10:~ # grep tinc /etc/rc.conf
tincd_enable="YES"
tincd_cfg="hiq"

root@f10:~ # /usr/local/etc/rc.d/tincd status
tincd is not running.

root@f10:~ # tinc -n hiq pid
289


I made changes to rc.d/tincd (diff attached) to add proper status capabilities:

root@f10:~ # service tincd status
tincd for hiq running with pid
289


Basically the same will probably apply to security/tinc.
Comment 1 Dirk Meyer freebsd_committer freebsd_triage 2020-03-27 14:16:21 UTC 
Thanks, patch is in testing ....

merge-quarterly should not be needed.
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-03-27 16:03:46 UTC 
A commit references this bug:

Author: dinoex
Date: Fri Mar 27 16:02:49 UTC 2020
New revision: 529266
URL: https://svnweb.freebsd.org/changeset/ports/529266

Log:
  - fix "service tincd status" for multiple instances
  PR:		245095
  Submitted by:	errit@weinberg2.de

Changes:
  head/security/tinc/Makefile
  head/security/tinc/files/tincd.in
  head/security/tinc-devel/Makefile
  head/security/tinc-devel/files/tincd.in
Comment 3 Dirk Meyer freebsd_committer freebsd_triage 2020-03-27 16:05:37 UTC 
committed with changes

the status message is now in sync with other scripts