Bug 245162 - x11-themes/kf5-breeze-icons: Fails to configure (missing xmllint dependency)
Summary: x11-themes/kf5-breeze-icons: Fails to configure (missing xmllint dependency)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-kde (group)
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2020-03-29 11:30 UTC by David Marec
Modified: 2020-03-29 17:51 UTC (History)
3 users (show)

See Also:
tcberner: maintainer-feedback+

Attachments
appends xmllint as a build dependency (349 bytes, patch)
2020-03-29 11:30 UTC, David Marec 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Marec 2020-03-29 11:30:33 UTC 
Created attachment 212828 [details]
appends xmllint as a build dependency

kf5-breeze-icons fails in the *configuration* stage if `xmllint` does not come as a dependency:

```
CMake Error at icons/CMakeLists.txt:20 (add_dependencies):
Cannot add target-level dependencies to non-existent target "breeze-validate-svg".
```

The required target 'breeze-validate-svg' will only be defined if both `sh` and `xmllint` were found:

```
find_program(SH_EXE sh)
find_program(XMLLINT_EXE xmllint)
if(SH_EXE AND XMLLINT_EXE)
[...]
        add_custom_target(breeze-validate-svg ALL
```

The attached patch appends `xmllint` into `BUILD_DEPENDS`.
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2020-03-29 13:23:05 UTC 
Moin moin 

How are you building your ports? 


mfg Tobias
Comment 2 David Marec 2020-03-29 13:50:51 UTC 
I'm running the build within a  poudriere:

One has to first uncheck some xml related options of the port dependencies.I didn't checked out which one exactly.

$ poudriere testport -j test -o x11-themes/kf5-breeze-icon


-- Performing Test HAVE_DATE_TIME - Success
CMake Error at icons/CMakeLists.txt:20 (add_dependencies):
  Cannot add target-level dependencies to non-existent target
  "breeze-validate-svg".

  The add_dependencies works for top-level logical targets created by the
  add_executable, add_library, or add_custom_target commands.  If you want to
  add file-level dependencies see the DEPENDS option of the add_custom_target
  and add_custom_command commands.


CMake Error at icons-dark/CMakeLists.txt:20 (add_dependencies):
  Cannot add target-level dependencies to non-existent target
  "breeze-validate-svg".

  The add_dependencies works for top-level logical targets created by the
  add_executable, add_library, or add_custom_target commands.  If you want to
  add file-level dependencies see the DEPENDS option of the add_custom_target
  and add_custom_command commands.




The issue was reported on a french irc channel, where a user hit this  by  calling a regular poudriere bulk.
Comment 3 Tobias C. Berner freebsd_committer freebsd_triage 2020-03-29 15:03:32 UTC 
 Should be fixed now.
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-03-29 15:04:03 UTC 
A commit references this bug:

Author: tcberner
Date: Sun Mar 29 15:03:00 UTC 2020
New revision: 529805
URL: https://svnweb.freebsd.org/changeset/ports/529805

Log:
  x11-themes/kf5-breeze-icons: fix cmake with respect to optional xmllint

  PR:		245162
  Reported by:	David Marec <david@lapinbilly.eu>

Changes:
  head/x11-themes/kf5-breeze-icons/files/
  head/x11-themes/kf5-breeze-icons/files/patch-D28407