Created attachment 212843 [details] Makefile diff When building the emulators/wine-devel port, make reports that the port links against libinotify.so (port devel/libinotify) and libunwind.so (port devel/libunwind), but these are missing from LIB_DEPENDS. The attached svnlite diff rectifies this omission. This is but a minor thing and I know that the maintainers of the WINE ports are already busy with bug #244368 and bug #244369.
This won't happen in a clean build environment, but indeed is an issue, so thank you for reporting this. I plan on removing this dependency by means of advising ./configure accordingly instead of adding dependencies unless anyone has a good reason to the contrary - but note that anyone using our packages or building packages themselves via poudriere or similar will already be in exactly that scenario.
(In reply to Gerald Pfeifer from comment #1) These could be added as OPTIONS I guess, but I think your suggestion is even better.
A commit references this bug: Author: gerald Date: Thu Apr 2 18:54:51 UTC 2020 New revision: 530401 URL: https://svnweb.freebsd.org/changeset/ports/530401 Log: Explicitly configure --without-unwind so that the presence of the devel/libunwind port does not pull in an implicit dependency that is not tracked properly. Reported by: Andy Mender <andymenderunix@gmail.com> PR: 245172 Changes: head/emulators/wine-devel/Makefile
The case of libunwind should now be addressed. We could do the very same for libinotify, but I'd like to look into something there first.
A commit references this bug: Author: gerald Date: Fri Apr 24 21:28:23 UTC 2020 New revision: 532899 URL: https://svnweb.freebsd.org/changeset/ports/532899 Log: Backport r530401 | gerald | 2020-04-02 from our wine-devel companion: Explicitly configure --without-unwind so that the presence of the devel/libunwind port does not pull in an implicit dependency that is not tracked properly. Reported by: Andy Mender <andymenderunix@gmail.com> PR: 245172 Changes: head/emulators/wine/Makefile
(In reply to Gerald Pfeifer from comment #4) > The case of libunwind should now be addressed. We could do the very > same for libinotify, but I'd like to look into something there first. My idea for libinotify did not work out, so I'll disable this via a configure switch -- in alignment with your agreement in comment #2. I plan on MFHing this and backporting it to emulators/wine.
A commit references this bug: Author: gerald Date: Sat May 9 10:48:18 UTC 2020 New revision: 534732 URL: https://svnweb.freebsd.org/changeset/ports/534732 Log: Explicitly configure --without-inotify so that the presence of the devel/libinotify port does not pull in an implicit dependency that is not tracked properly. Reported by: Andy Mender <andymenderunix@gmail.com> PR: 245172 MFH: 2020Q2 (blanket: missing dependency) Changes: head/emulators/wine-devel/Makefile
A commit references this bug: Author: gerald Date: Sun May 10 10:18:39 UTC 2020 New revision: 534843 URL: https://svnweb.freebsd.org/changeset/ports/534843 Log: MFH: r530401 Explicitly configure --without-unwind so that the presence of the devel/libunwind port does not pull in an implicit dependency that is not tracked properly. Reported by: Andy Mender <andymenderunix@gmail.com> PR: 245172 Approved by: portmgr (blanket: dependency issue) Changes: _U branches/2020Q2/ branches/2020Q2/emulators/wine-devel/Makefile
A commit references this bug: Author: gerald Date: Mon May 11 09:00:10 UTC 2020 New revision: 534895 URL: https://svnweb.freebsd.org/changeset/ports/534895 Log: MFH: r534732 Explicitly configure --without-inotify so that the presence of the devel/libinotify port does not pull in an implicit dependency that is not tracked properly. Reported by: Andy Mender <andymenderunix@gmail.com> PR: 245172 Approved by: portmgr (blanket: dependency issue) Changes: _U branches/2020Q2/ branches/2020Q2/emulators/wine-devel/Makefile
A commit references this bug: Author: gerald Date: Tue May 12 07:44:12 UTC 2020 New revision: 534975 URL: https://svnweb.freebsd.org/changeset/ports/534975 Log: MFH: r532899 Backport r530401 | gerald | 2020-04-02 from our wine-devel companion: Explicitly configure --without-unwind so that the presence of the devel/libunwind port does not pull in an implicit dependency that is not tracked properly. Reported by: Andy Mender <andymenderunix@gmail.com> PR: 245172 Approved by: portmgr (blanket: dependency issue) Changes: _U branches/2020Q2/ branches/2020Q2/emulators/wine/Makefile
A commit references this bug: Author: gerald Date: Sat May 16 15:35:20 UTC 2020 New revision: 535468 URL: https://svnweb.freebsd.org/changeset/ports/535468 Log: Explicitly configure --without-inotify so that the presence of the devel/libinotify port does not pull in an implicit dependency that is not tracked properly. Reported by: Andy Mender <andymenderunix@gmail.com> PR: 245172 MFH: 2020Q2 (blanket: missing dependency) Changes: head/emulators/wine/Makefile
So... both wine-devel and wine have seen the changes re both libunwind and libinotify, I have pushed the libunwind changes for both back to the current quarterly branch, libinotify for wine-devel and I queued the same for wine to be done in the next week or so. With that I am closing this report. Thanks for the feedback! (There is a similar change re libusb which I've looked at and plan on applying changes later on - that one appears to be lower prio, though.)
A commit references this bug: Author: gerald Date: Mon May 18 22:11:31 UTC 2020 New revision: 535794 URL: https://svnweb.freebsd.org/changeset/ports/535794 Log: MFH: r535468 Explicitly configure --without-inotify so that the presence of the devel/libinotify port does not pull in an implicit dependency that is not tracked properly. Reported by: Andy Mender <andymenderunix@gmail.com> PR: 245172 Approved by: ports-secteam (joneum), portmgr (blanket: dependency issue) Changes: _U branches/2020Q2/ branches/2020Q2/emulators/wine/Makefile
That was the last commit I can see related to this. Should I have missed anything please let me know.