Created attachment 213592 [details] Adding the port diff Adding a new port as described in Porters handbook "The system provides authentication for system access (login) and other applications requiring authentication that is secure against passive attacks based on replaying captured reusable passwords. OTP evolved from the S/KEY (S/KEY is a trademark of Bellcore) One-Time Password System that was released by Bellcore." https://github.com/blackm0re/pyotp2289
Thank you for the new port and patch Simeon Minor tweak: to the do-test target, add "-o addopts=" (without quotes) to the end of the pytest line. This ensures that any current or future pytest.ini or setup.cfg:[pytest] lines are ignored (such as forced --coverage inclusion, etc) I'd probably also put this under security as the primary category as well
Created attachment 213595 [details] Modified diff Hi and thank you for your feedback. Attaching a modified svn diff.
Hi again. Not sure if I understand the flagging system. Do you need more feedback from me?
(In reply to Simeon Simeonov from comment #3) The only additional thing maintainers can provide is confirmation of QA (portlint, poudriere) which can help to pickup issues early, for more info and instructions see: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-testing.html But otherwise no other feedback. People can tell when something needs their response/acknowledgement, if their (bugzilla) email is in the value of a flag (like maintainer-feedback) with the ? value set In the previous change to this issue I made, i changed it from needing feedback ? to + (provided feedback, in this case, the updated patch)
Created attachment 213714 [details] Testing security/py-pyotp2289 Thank you again for the feedback! I ran portlint before submitting the port. Submitting output (script pyotp2289.log) of the testing sequence (and portlint).
A commit references this bug: Author: dbaio Date: Mon Apr 27 23:50:17 UTC 2020 New revision: 533214 URL: https://svnweb.freebsd.org/changeset/ports/533214 Log: Add security/py-pyotp2289 Pure Python implementation of RFC-2289 - "A One-Time Password System" "The system provides authentication for system access (login) and other applications requiring authentication that is secure against passive attacks based on replaying captured reusable passwords. OTP evolved from the S/KEY (S/KEY is a trademark of Bellcore) One-Time Password System that was released by Bellcore." WWW: https://github.com/blackm0re/pyotp2289 PR: 245755 Submitted by: Simeon Simeonov <sgs@pichove.org> Changes: head/security/Makefile head/security/py-pyotp2289/ head/security/py-pyotp2289/Makefile head/security/py-pyotp2289/distinfo head/security/py-pyotp2289/pkg-descr
A commit references this bug: Author: dbaio Date: Mon Apr 27 23:50:55 UTC 2020 New revision: 54077 URL: https://svnweb.freebsd.org/changeset/doc/54077 Log: Add Simeon Simeonov to contributors Maintainer of: security/py-pyotp2289 PR: 245755 Changes: head/en_US.ISO8859-1/articles/contributors/contrib.additional.xml
Committed, thanks for your contribution.