Bug 245793 - devel/bitkeeper: stage-qa results
Summary: devel/bitkeeper: stage-qa results
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks: 247160
  Show dependency treegraph
 
Reported: 2020-04-21 13:24 UTC by Gian-Simon Purkert
Modified: 2021-03-27 03:10 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (cy)


Attachments
My Makefile (910 bytes, text/plain)
2020-04-21 13:40 UTC, Gian-Simon Purkert
no flags Details
A collection of patches (23.00 KB, patch)
2021-03-26 05:19 UTC, Cy Schubert
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gian-Simon Purkert 2020-04-21 13:24:30 UTC
====> Running Q/A tests (stage-qa)
Warning: 'bitkeeper/bk' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'bitkeeper/gui/lib/Tktable2.10/libTktable2.10.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'bitkeeper/gui/bin/tclsh' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'bitkeeper/gui/bin/bkgui' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Error: /usr/local/bitkeeper/bk is linked to /usr/local/lib/libtommath.so.1 from math/libtommath but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libtommath.so:math/libtommath
Error: /usr/local/bitkeeper/gui/bin/bkgui is linked to /usr/local/lib/libXft.so.2 from x11-fonts/libXft but it is not declared as a dependency
Warning: you need USE_XORG+=xft
Error: /usr/local/bitkeeper/gui/bin/bkgui is linked to /usr/local/lib/libfreetype.so.6 from print/freetype2 but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libfreetype.so:print/freetype2
Error: /usr/local/bitkeeper/gui/bin/bkgui is linked to /usr/local/lib/libfontconfig.so.1 from x11-fonts/fontconfig but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libfontconfig.so:x11-fonts/fontconfig
Error: /usr/local/bitkeeper/gui/bin/bkgui is linked to /usr/local/lib/libXrender.so.1 from x11/libXrender but it is not declared as a dependency

In my Makefile i have that:

LIB_DEPENDS=    libtomcrypt.so:security/libtomcrypt \
		libpcre.so:devel/pcre \
		liblz4.so:archivers/liblz4 \
		libXft.so:x11-fonts/libXft \
		libtommath.so:math/libtommath \
		libfreetype.so:print/freetype2 \
		libfontconfig.so:x11-fonts/fontconfig
Comment 1 Gian-Simon Purkert 2020-04-21 13:37:20 UTC
Because stage-qa warning:
USE_XORG+=xft

I have:

USE_XORG=	x11 xrender xft
Comment 2 Gian-Simon Purkert 2020-04-21 13:40:45 UTC
Created attachment 213638 [details]
My Makefile

Maybe it helps ONLY_FOR_ARCHS=	amd64 i386 etc
Comment 3 Cy Schubert freebsd_committer freebsd_triage 2020-04-21 14:24:20 UTC
What does uname -a tell you?
Comment 4 Gian-Simon Purkert 2020-04-21 14:38:20 UTC
#uname-a
FreeBSD freeb 12.1-RELEASE-p3 FreeBSD 12.1-RELEASE-p3 GENERIC  amd64

And thank you very much for porting Bitkeeper!!
Comment 5 Cy Schubert freebsd_committer freebsd_triage 2020-04-21 15:19:09 UTC
I didn't do the original port. pfg@ did. I simply needed for something new that came up (I've been asked to help out at nwtime.org because of my ntp work here at freebsd.org, they use bitkeeper). A search of wiki.freebsd.org led me to pfg@. I asked him if I could take it and commit it. He agreed. All I did was get DEPENDS to depend properly. It's been a team effort.
Comment 6 Gian-Simon Purkert 2020-04-21 16:16:16 UTC
Same-same with the wiki and the WIP from pfg@.
Nice that Bitkeeper is now in the port-tree.

Remove Bitkeeper from WantedPorts its in devel/bitkeeper:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245791
Comment 7 Cy Schubert freebsd_committer freebsd_triage 2020-05-13 02:08:37 UTC
Can this PR be closed?
Comment 8 Gian-Simon Purkert 2020-05-19 11:02:36 UTC
With your Makefile the GUI-Components of Bitkeeper will no work:

Running Q/A tests (stage-qa):
bkgui is linked to /usr/local/lib/libfreetype.so.6
etc...

Maybe a build-option with "Gui", would be the cleanest thing
Comment 9 Gian-Simon Purkert 2020-06-11 09:39:37 UTC
On a fresh installed system i have that in the Q/A tests:

====> Running Q/A tests (stage-qa)
Warning: 'bitkeeper/bk' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'bitkeeper/gui/bin/tclsh' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'bitkeeper/gui/bin/bkgui' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'bitkeeper/gui/lib/Tktable2.10/libTktable2.10.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Error: /usr/local/bitkeeper/bk is linked to /usr/local/lib/libtommath.so.1 from math/libtommath but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libtommath.so:math/libtommath
Error: /usr/local/bitkeeper/gui/bin/bkgui is linked to /usr/local/lib/libXft.so.2 from x11-fonts/libXft but it is not declared as a dependency
Warning: you need USE_XORG+=xft
Error: /usr/local/bitkeeper/gui/bin/bkgui is linked to /usr/local/lib/libfreetype.so.6 from print/freetype2 but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libfreetype.so:print/freetype2
Error: /usr/local/bitkeeper/gui/bin/bkgui is linked to /usr/local/lib/libfontconfig.so.1 from x11-fonts/fontconfig but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libfontconfig.so:x11-fonts/fontconfig
Error: /usr/local/bitkeeper/gui/bin/bkgui is linked to /usr/local/lib/libXrender.so.1 from x11/libXrender but it is not declared as a dependency
Warning: you need USE_XORG+=xrender


So i think we need that additionally in the Makefile:

LIB_DEPENDS+=libtommath.so:math/libtommath
LIB_DEPENDS+=libfreetype.so:print/freetype2
LIB_DEPENDS+=libfontconfig.so:x11-fonts/fontconfig

USE_XORG+=xft
USE_XORG+=xrender
Comment 10 Gian-Simon Purkert 2021-03-25 22:50:37 UTC
Ping?
Comment 11 Cy Schubert freebsd_committer freebsd_triage 2021-03-25 23:36:03 UTC
These are not fatal errors but are displayed in developer mode.
Comment 12 Cy Schubert freebsd_committer freebsd_triage 2021-03-26 05:19:39 UTC
Created attachment 223596 [details]
A collection of patches

Can you please give this collection of four commits a try? This will resolve this and PR/247160 and other issues with the port.
Comment 13 commit-hook freebsd_committer freebsd_triage 2021-03-27 02:45:25 UTC
A commit references this bug:

Author: cy
Date: Sat Mar 27 02:44:48 UTC 2021
New revision: 569285
URL: https://svnweb.freebsd.org/changeset/ports/569285

Log:
  devel/bitkeeper: register all dependencies

  PR:		245793
  Reported by:	Gian-Simon Purkert <gspurki@gmail.com>

Changes:
  head/devel/bitkeeper/Makefile
Comment 14 Cy Schubert freebsd_committer freebsd_triage 2021-03-27 03:10:05 UTC
Fixed.