Bug 245857 - games/gnuchess: Update to 6.2.6
Summary: games/gnuchess: Update to 6.2.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2020-04-23 16:48 UTC by Gian-Simon Purkert
Modified: 2020-04-24 18:16 UTC (History)
1 user (show)

See Also:

Attachments
Update to 6.2.6 (3.27 KB, patch)
2020-04-23 16:48 UTC, Gian-Simon Purkert 		no flags Details | Diff
additional improvements on top of submitter's patch (2.71 KB, patch)
2020-04-24 15:54 UTC, Fernando Apesteguía 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gian-Simon Purkert 2020-04-23 16:48:36 UTC 
Created attachment 213729 [details]
Update to 6.2.6
Comment 1 Gian-Simon Purkert 2020-04-23 16:53:05 UTC 
I hope that's the right way to send in update diffs.

Sorry for any inconvenience
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2020-04-24 15:54:19 UTC 
Created attachment 213757 [details]
additional improvements on top of submitter's patch

Hi!

Thanks for your contribution. It's really appreciated. I attached a new patch just for reference:

- Don't remove the %%NLS%% at the beginning of the lines in pkg-plist. Those files are only installed if the NLS option is ON and the port will fail to stage/package otherwise.

- No need to set PORTREVISION=0, it's its default value if unset.

- I removed the duplicated .info file and left only the one in the INFO= section of the Makefile (listing it in pkg-plist is deprecated).
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-04-24 15:58:00 UTC 
A commit references this bug:

Author: fernape
Date: Fri Apr 24 15:57:55 UTC 2020
New revision: 532765
URL: https://svnweb.freebsd.org/changeset/ports/532765

Log:
  games/gnuchess: update to 6.2.6

  While here:

  * Remove .info files from pkg-plist
  * Do not install duplicated .info file

  PR:	245857
  Submitted by:	gspurki@gmail.com

Changes:
  head/games/gnuchess/Makefile
  head/games/gnuchess/distinfo
  head/games/gnuchess/pkg-plist
Comment 4 Gian-Simon Purkert 2020-04-24 18:14:31 UTC 
Thank you very much for the hints!

Have a nice day.