Bug 245896 - multimedia/aom: properly detect architecture on powerpc*
Summary: multimedia/aom: properly detect architecture on powerpc*
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: powerpc Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-25 01:08 UTC by Piotr Kubaj
Modified: 2020-04-25 02:22 UTC (History)
2 users (show)

See Also:
jbeich: maintainer-feedback+
jbeich: merge-quarterly+


Attachments
patch (407 bytes, patch)
2020-04-25 01:08 UTC, Piotr Kubaj
pkubaj: maintainer-approval? (jbeich)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2020-04-25 01:08:12 UTC
Created attachment 213769 [details]
patch

build/cmake/aom_configure.cmake only checks whether there is "^ppc" in architecture string (so e.g. ppc64le also matches), but our powerpc doesn't match.

This results in:
CMake Warning at build/cmake/aom_configure.cmake:80 (message):
  The architecture powerpc64 is not supported, falling back to the generic
  target
Call Stack (most recent call first):
  CMakeLists.txt:35 (include)
Comment 1 Jan Beich freebsd_committer freebsd_triage 2020-04-25 02:07:00 UTC
Comment on attachment 213769 [details]
patch

I'd prefer to simply patch the source, so it can be upstreamed. NetBSD and OpenBSD also use powerpc* from `uname -p` (aka MACHINE_ARCH).
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-04-25 02:21:56 UTC
A commit references this bug:

Author: jbeich
Date: Sat Apr 25 02:21:15 UTC 2020
New revision: 532910
URL: https://svnweb.freebsd.org/changeset/ports/532910

Log:
  multimedia/aom: unbreak SIMD on powerpc*

  CMake Warning at build/cmake/aom_configure.cmake:80 (message):
    The architecture powerpc64 is not supported, falling back to the generic
    target
  Call Stack (most recent call first):
    CMakeLists.txt:35 (include)

  PR:		245896
  Reported by:	pkubaj

Changes:
  head/multimedia/aom/files/patch-build_cmake_aom__configure.cmake
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-04-25 02:21:57 UTC
A commit references this bug:

Author: jbeich
Date: Sat Apr 25 02:21:39 UTC 2020
New revision: 532911
URL: https://svnweb.freebsd.org/changeset/ports/532911

Log:
  MFH: r532910

  multimedia/aom: unbreak SIMD on powerpc*

  CMake Warning at build/cmake/aom_configure.cmake:80 (message):
    The architecture powerpc64 is not supported, falling back to the generic
    target
  Call Stack (most recent call first):
    CMakeLists.txt:35 (include)

  PR:		245896
  Reported by:	pkubaj
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2020Q2/
  branches/2020Q2/multimedia/aom/files/patch-build_cmake_aom__configure.cmake