Bug 246042 - [NEW PORT] net/py-wsdd: Web Service Discovery host daemon
Summary: [NEW PORT] net/py-wsdd: Web Service Discovery host daemon
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
: 246085 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-04-30 02:58 UTC by Hiroo Ono
Modified: 2020-05-04 20:40 UTC (History)
3 users (show)

See Also:


Attachments
wsdd port files (2.11 KB, patch)
2020-04-30 02:58 UTC, Hiroo Ono
no flags Details | Diff
wsdd port files (updated) (2.09 KB, patch)
2020-04-30 11:18 UTC, Hiroo Ono
no flags Details | Diff
wsdd port files (updated) (2.02 KB, patch)
2020-05-01 03:09 UTC, Hiroo Ono
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hiroo Ono 2020-04-30 02:58:07 UTC
Created attachment 213931 [details]
wsdd port files

wsdd is a Web Service Discovery host daemon that helps Windows hosts find
Samba shares without SMB1/CIFS enabled.
Since NetBIOS discovery is not supported by Windows anymore, wsdd makes hosts to appear in Windows again using the Web Service Discovery method.
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2020-04-30 06:57:57 UTC
Nice work!

Perhaps be a bit more verbose about the description?
COMMENT=	Web Service Discovery (WSD) host daemon for Samba

Shouldn't USES be python:3.5+,run as it's only a run dependency?
https://svnweb.freebsd.org/ports/head/Mk/Uses/python.mk?revision=532396&view=markup#l39

Shouldn't NO_ARCH be set?
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-arch.html

Doesn't matter much but I think you can omit DOC_FILES as they doesn't provide any useful documentation.

Manpage is missing, that should be installed.

post-patch --> Shebangfix doesn't work?
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/uses-shebangfix.html

Best regards,
Daniel
Comment 2 Hiroo Ono 2020-04-30 11:18:11 UTC
Created attachment 213940 [details]
wsdd port files (updated)
Comment 3 Hiroo Ono 2020-04-30 11:19:22 UTC
Thank you.
Updated the patch according to your suggestions.
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2020-04-30 11:56:18 UTC
Remove post-patch section as it's not needed
@${MKDIR} ${STAGEDIR}${DOCSDIR} isn't needed
While not in the handbook (yet?) I'm fairly sure that you need to use the prefix py- as mentioned here https://wiki.freebsd.org/Python/PortsPolicy#Prefixing_.28py-.2A.29 in package name (and directory).

Best regards,
Daniel
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2020-04-30 19:52:06 UTC
(In reply to daniel.engberg.lists from comment #4)
Just to be clear about prefix, like this:
https://svnweb.freebsd.org/ports/head/devel/py-six/Makefile?revision=524438&view=markup#l8
Comment 6 Hiroo Ono 2020-05-01 03:09:34 UTC
Created attachment 213968 [details]
wsdd port files (updated)

Sorry for my incomplete correction.
Updated the patch again.
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2020-05-02 17:21:45 UTC
Passes poudriere testport on 12.1-RELEASE (AMD64)
Comment 8 commit-hook freebsd_committer freebsd_triage 2020-05-02 17:57:38 UTC
A commit references this bug:

Author: mandree
Date: Sat May  2 17:57:00 UTC 2020
New revision: 533700
URL: https://svnweb.freebsd.org/changeset/ports/533700

Log:
  new port: net/py-wsdd, web service discovery host daemon

  wsdd implements a Web Service Discovery host daemon. This enables (Samba)
  hosts, like your local NAS device, to be found by Web Service Discovery
  Clients like Windows.

  WWW: https://github.com/christgau/wsdd

  PR:		246042
  Submitted by:	Hiroo Ono <hiroo.ono+freebsd@gmail.com> (maintainer)

Changes:
  head/net/Makefile
  head/net/py-wsdd/
  head/net/py-wsdd/Makefile
  head/net/py-wsdd/distinfo
  head/net/py-wsdd/pkg-descr
  head/net/py-wsdd/pkg-message
Comment 9 Matthias Andree freebsd_committer freebsd_triage 2020-05-04 20:40:18 UTC
*** Bug 246085 has been marked as a duplicate of this bug. ***