Bug 246346 - ports-mgmt/portlint: Complains about unsorted NOT_FOR_ARCHS because it treats comments as values
Summary: ports-mgmt/portlint: Complains about unsorted NOT_FOR_ARCHS because it treats...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-10 06:16 UTC by Yuri Victorovich
Modified: 2020-05-30 13:54 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2020-05-10 06:16:08 UTC 
Testcase: devel/kokkos

> [yuri@xx /usr/ports/devel/kokkos]$ portlint -C
> WARN: Makefile: [11]: the arguments to NOT_FOR_ARCHS are not sorted.  Please consider sorting them.
Comment 1 Joe Marcus Clarke freebsd_committer freebsd_triage 2020-05-30 13:01:37 UTC 
Fixed in my repo, pending new release.
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-05-30 13:46:58 UTC 
A commit references this bug:

Author: marcus
Date: Sat May 30 13:46:43 UTC 2020
New revision: 537082
URL: https://svnweb.freebsd.org/changeset/ports/537082

Log:
  Update to 2.19.0.

  * Do not be overly critical of macros which are used before declaration in DEPENDS
  * Do not treat comments to ONLY_FOR_ARCHS and NOT_FOR_ARCHS as sortable data [1]
  * Check for PORTSDIR defined in /etc/make.conf [2]
  * Do not warn about ${DISTNAME}${EXTRACT_SFX} in DISTFILES if USE_GITHUB=nodefault [3]
  * Thoroughly check for an OPTION description [4]
  * Specify flag equivalency for -A in portlint(1) [5]

  PR:		246346 [1]
  		244807 [2]
  		244741 [3]
  		244480 [4]
  		245338 [5]
  Submitted by:	0mp [3]
  		kevans [5]

Changes:
  head/ports-mgmt/portlint/Makefile
  head/ports-mgmt/portlint/src/portlint.1
  head/ports-mgmt/portlint/src/portlint.pl
Comment 3 Joe Marcus Clarke freebsd_committer freebsd_triage 2020-05-30 13:54:41 UTC 
Fixed in 2.19.0.