Bug 246434 - dns/powerdns: Wrong pidfile in rc script
Summary: dns/powerdns: Wrong pidfile in rc script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kurt Jaeger
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-05-13 07:40 UTC by Dominik Lisiak
Modified: 2020-05-14 13:02 UTC (History)
2 users (show)

See Also:
tremere: maintainer-feedback+

Attachments
Fix pkg-plist, pidfile in rc.d script and more (10.18 KB, patch)
2020-05-13 14:08 UTC, Ralf van der Enden 		tremere: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Lisiak 2020-05-13 07:40:03 UTC 
I cannot stop the server using rc stop command:

# /usr/local/etc/rc.d/pdns stop
pdns not running? (check /var/run/pdns/pdns_server.pid).

'pidfile=/var/run/pdns/pdns_server.pid' line in rc script seems to be the problem. The pid file is created at '/var/run/pdns/pdns.pid'. If I remove the mentioned line everything seems to work fine.
Comment 1 Ralf van der Enden 2020-05-13 09:03:25 UTC 
I'm working on a patch already, since there's an issue with pkg-plist as well.

Should be ready somewhere today.

Thanks for your report. I totally missed this one.
Comment 2 Ralf van der Enden 2020-05-13 14:08:35 UTC 
Created attachment 214452 [details]
Fix pkg-plist, pidfile in rc.d script and more


- Add missing entries to pkg-plist
- Add ixfrdist tool
- Change pidfile back to ${name}.pid in the rc.d script
- Pet portlint a bit (regenerate files/patch-configure and ran Makefile though portfmt)
- Remove patch-dns_random.cc (only needed on 12.0, which is EoL)
- Move upgrade instructions from pkg-install to pkg-message
- Bump PORTREVISION

Upgrading the port now shows a message about required schema changes for several backends.
Comment 3 Steve Wills freebsd_committer freebsd_triage 2020-05-13 14:36:13 UTC 
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/145628813
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2020-05-14 13:02:40 UTC 
Committed, thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-05-14 13:02:57 UTC 
A commit references this bug:

Author: pi
Date: Thu May 14 13:02:38 UTC 2020
New revision: 535231
URL: https://svnweb.freebsd.org/changeset/ports/535231

Log:
  dns/powerdns: fix pkg-plist, pidfile in rc.d script and more

  - Add missing entries to pkg-plist
  - Add ixfrdist tool
  - Change pidfile back to ${name}.pid in the rc.d script
  - Pet portlint a bit (regenerate files/patch-configure and ran
    Makefile though portfmt)
  - Remove patch-dns_random.cc (only needed on 12.0, which is EoL)
  - Move upgrade instructions from pkg-install to pkg-message
  - Bump PORTREVISION
  - Upgrading the port now shows a message about required schema
    changes for several backends.

  PR:		246434
  Submitted by:	Ralf van der Enden <tremere@cainites.net> (maintainer)
  Reported by:	Dominik Lisiak <dominik.lisiak@bemsoft.pl>

Changes:
  head/dns/powerdns/Makefile
  head/dns/powerdns/files/patch-configure
  head/dns/powerdns/files/patch-dns_random.cc
  head/dns/powerdns/files/pdns.in
  head/dns/powerdns/files/pkg-message.in
  head/dns/powerdns/pkg-install
  head/dns/powerdns/pkg-plist