Bug 246882 - ports-mgmt/portlint: use of uninitialized value $makevar{"USE_GITHUB"} in string ne at portlint line 3059
Summary: ports-mgmt/portlint: use of uninitialized value $makevar{"USE_GITHUB"} in str...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-30 21:42 UTC by Gerald Pfeifer
Modified: 2020-05-31 19:00 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Pfeifer freebsd_committer freebsd_triage 2020-05-30 21:42:41 UTC 
Running `portlint -C` in devel-mgmt/portlint itself now results in

  Use of uninitialized value $makevar{"USE_GITLUB"} in string ne at portlint line 3059.
  Use of uninitialized value $makevar{"USE_GITLUB"} in string ne at portlint line 3059.

I believe this is due to the patch from PR 244741 included in portlint 2.19.0.
  
This is with Perl 5.26.3, for example on ref11-i386.
Comment 1 Joe Marcus Clarke freebsd_committer freebsd_triage 2020-05-30 23:16:30 UTC 
Fixed in 2.19.1.
Comment 2 Gerald Pfeifer freebsd_committer freebsd_triage 2020-05-30 23:53:48 UTC 
(In reply to Joe Marcus Clarke from comment #1)
> Fixed in 2.19.1.

I'm afraid not this one's still there:

    % cd $PORTSDIR/lang/gcc10-devel/ && portlint -C
    WARN: .../lang/gcc10-devel/pkg-plist: You have defined USE_LDCONFIG, but...
    WARN: Makefile: [15]: the arguments to ONLY_FOR_ARCHS are not sorted. ...
==> Use of uninitialized value $makevar{"USE_GITLAB"} in string ne at
==>     /home/gerald/bin/portlint line 3060.
    WARN: Consider to set DEVELOPER=yes in /etc/make.conf
Comment 3 Joe Marcus Clarke freebsd_committer freebsd_triage 2020-05-31 15:32:45 UTC 
Think is got in in 2.19.2.  This was a tricky one.
Comment 4 Gerald Pfeifer freebsd_committer freebsd_triage 2020-05-31 19:00:00 UTC 
Thank you! Indeed 2.19.2 addresses all issues I am aware of.

And I did notice the following in the latest revision. ;-)
 
  # This bit of magic is interesting and