Bug 246938 - math/arpack-ng: allow to build arpack-ng with openblas
Summary: math/arpack-ng: allow to build arpack-ng with openblas
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-06-02 14:15 UTC by Oleg Sidorkin
Modified: 2024-12-19 18:35 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
svn diff patch to allow math/arpack-ng to link against math/openblas (504 bytes, patch)
2020-06-02 14:15 UTC, Oleg Sidorkin
no flags Details | Diff
svn diff patch to allow math/arpack-ng to link against math/openblas (476 bytes, patch)
2020-06-02 14:56 UTC, Oleg Sidorkin
no flags Details | Diff
Offer a list of BLAS-options, use blaslapack.mk (2.02 KB, patch)
2024-12-13 02:18 UTC, Mikhail T.
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Sidorkin 2020-06-02 14:15:23 UTC
Created attachment 215166 [details]
svn diff patch to allow math/arpack-ng to link against math/openblas

Some consumers of arpack-ng (e.g. math/scilab) provides user a choice between atlas and openblas. However arpack-ng cannot be linked against openblas, so scilab gets linked against both libraries.

Attached patch adds support for WITH_BLAS=openblas option.
Comment 1 Oleg Sidorkin 2020-06-02 14:56:45 UTC
Created attachment 215168 [details]
svn diff patch to allow math/arpack-ng to link against math/openblas

it seems that openblas provides lapack functions also
Comment 2 Steve Wills freebsd_committer freebsd_triage 2020-06-17 02:37:16 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/156988815
Comment 3 Gleb Popov freebsd_committer freebsd_triage 2021-03-20 08:16:18 UTC
I wonder why this option is not made visible to users by means of OPTIONS?
Comment 4 Oleg Sidorkin 2021-03-22 10:44:28 UTC
(In reply to Gleb Popov from comment #3)

I see 2 problems:

1) There is some kind of global switch in Mk/Uses/blaslapack.mk. I think there should be a global flag to switch default blas implementation for all ports.

2) Unfortunately, lapack parts of openblas are not drop-in replacement of math/lapack. Some tests in dependent libraries fail with lapack from openblas.
Comment 5 Mikhail T. 2024-12-13 02:18:24 UTC
Created attachment 255827 [details]
Offer a list of BLAS-options, use blaslapack.mk

I think, blaslapack.mk should derive the desired implementation from the DEFAULT_VERSIONS list, instead of always defaulting to netlib.
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-12-19 18:34:06 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a551a619c2300b8ffa5492d4a4ab7b2471db7e04

commit a551a619c2300b8ffa5492d4a4ab7b2471db7e04
Author:     Mikhail T. <freebsd-2024@virtual-estates.net>
AuthorDate: 2024-12-19 18:29:18 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2024-12-19 18:32:59 +0000

    math/arpack-ng: OPTIONalize blas dependency

    Co-authored-by: Gleb Popov <arrowd@FreeBSD.org>
    PR:             246938
    Approved by:    maintainer timeout

 math/arpack-ng/Makefile | 37 ++++++++++++-------------------------
 1 file changed, 12 insertions(+), 25 deletions(-)