Bug 246947 - mail/dovecot: example-config files lost the freebsd hierachy
Summary: mail/dovecot: example-config files lost the freebsd hierachy
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Larry Rosenman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-03 01:20 UTC by Bernd Roth
Modified: 2020-06-04 15:29 UTC (History)
0 users

See Also:
ler: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bernd Roth 2020-06-03 01:20:34 UTC 
Hello, i did a long time preparation/learning/testing for a dovecot installation and started yesterday to go "live" from scratch with dovecot 2.3.10.1 and got more errors than usual. Long story short: I compared the example-config with older 2.3.9.3 and noticed that the examples point to /etc/dovecot now. But according to /usr/local/etc/rc.d/dovecot the /usr/local/etc/dovecot is still the base configuration directory:

# dovecot_config (str):         Path to dovecot.conf
#                               Default: /usr/local/etc/dovecot/dovecot.conf

This is very confusing for anyone who is in need for the examples and yes i read the README that the examples need to be modified before usage. I would like to keep the given default structure but i'm unsure what the actual default is. Is there an intention to move to /etc/dovecot? That would break the "man hier" structure for unknown to me but good reason?

I think i found the wind of change here:

https://svnweb.freebsd.org/ports/head/mail/dovecot/Makefile?r1=535778&r2=535777&pathrev=535778

at line 135 there is something that looks like a sed replacement command for /etc/dovecot entries in conf.d files into ${PREFIX}/etc/dovecot that was removed. I don't understand the CVE Reports and so i can't recognize if there was a reason to remove that default. If so i do apologize for the report.

May the health be with you...
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-06-03 02:16:57 UTC 
A commit references this bug:

Author: ler
Date: Wed Jun  3 02:16:30 UTC 2020
New revision: 537587
URL: https://svnweb.freebsd.org/changeset/ports/537587

Log:
  mail/dovecot: restore the REINPLACE_CMD for the example config.

  Overzealous removal.

  PR:		246947
  Submitted by:	gwbr0601@yahoo.de
  Pointy Hat To:	ler

Changes:
  head/mail/dovecot/Makefile
Comment 2 Larry Rosenman freebsd_committer freebsd_triage 2020-06-03 02:17:07 UTC 
Yeah, sorry about that.  Fixed.
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-06-04 15:29:26 UTC 
A commit references this bug:

Author: ler
Date: Thu Jun  4 15:29:20 UTC 2020
New revision: 537905
URL: https://svnweb.freebsd.org/changeset/ports/537905

Log:
  MFH: r537587 r537837

  mail/dovecot: restore the REINPLACE_CMD for the example config.

  Overzealous removal.

  PR:		246947
  Submitted by:	gwbr0601@yahoo.de
  Pointy Hat To:	ler

  mail/dovecot: fix example config *.conf.ext REINPLACE missed in r537587.

  PR:		246963
  Submitted by:	kfv@irbug.org

  Approved by:	ports-secteam (joneum)

Changes:
_U  branches/2020Q2/
  branches/2020Q2/mail/dovecot/Makefile