Bug 246963 - mail/dovecot: not all example-configs are modified properly
Summary: mail/dovecot: not all example-configs are modified properly
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Larry Rosenman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-03 16:58 UTC by Faraz Vahedi
Modified: 2020-06-04 15:29 UTC (History)
0 users

See Also:
ler: maintainer-feedback+

Attachments
Fix REINPLACE_CMD to include all example files (709 bytes, patch)
2020-06-03 16:58 UTC, Faraz Vahedi 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Faraz Vahedi 2020-06-03 16:58:53 UTC 
Created attachment 215204 [details]
Fix REINPLACE_CMD to include all example files

The first REINPLACE_CMD of the post-patch section is not targeting files ending in .ext under example-config/, which causes examples to point to an unchanged and therefore wrong path.
I am pleased to attach herewith a simple patch for your consideration.
Comment 1 Larry Rosenman freebsd_committer freebsd_triage 2020-06-03 19:31:26 UTC 
Thanks.  Working on it.
Comment 2 Larry Rosenman freebsd_committer freebsd_triage 2020-06-03 19:35:38 UTC 
Committed, Thanks.
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-06-03 19:35:53 UTC 
A commit references this bug:

Author: ler
Date: Wed Jun  3 19:35:21 UTC 2020
New revision: 537837
URL: https://svnweb.freebsd.org/changeset/ports/537837

Log:
  mail/dovecot: fix example config *.conf.ext REINPLACE missed in r537587.

  PR:		246963
  Submitted by:	kfv@irbug.org
  MFH:		2020Q2

Changes:
  head/mail/dovecot/Makefile
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-06-04 15:29:25 UTC 
A commit references this bug:

Author: ler
Date: Thu Jun  4 15:29:21 UTC 2020
New revision: 537905
URL: https://svnweb.freebsd.org/changeset/ports/537905

Log:
  MFH: r537587 r537837

  mail/dovecot: restore the REINPLACE_CMD for the example config.

  Overzealous removal.

  PR:		246947
  Submitted by:	gwbr0601@yahoo.de
  Pointy Hat To:	ler

  mail/dovecot: fix example config *.conf.ext REINPLACE missed in r537587.

  PR:		246963
  Submitted by:	kfv@irbug.org

  Approved by:	ports-secteam (joneum)

Changes:
_U  branches/2020Q2/
  branches/2020Q2/mail/dovecot/Makefile