Bug 246969 - graphics/libdrm: fix build on GCC architectures
Summary: graphics/libdrm: fix build on GCC architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-04 08:44 UTC by Piotr Kubaj
Modified: 2020-06-06 09:23 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (x11)

Attachments
patch (789 bytes, patch)
2020-06-04 08:44 UTC, Piotr Kubaj 		pkubaj: maintainer-approval? (x11)
 Details | Diff
patch with upstream MR commit (951 bytes, patch)
2020-06-04 09:16 UTC, Emmanuel Vadot 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2020-06-04 08:44:24 UTC 
Created attachment 215215 [details]
patch

sys/types.h needs to be included for u_int.

Error:
In file included from ../xf86drmMode.c:46:
/usr/include/sys/sysctl.h:1101: error: expected declaration specifiers or '...' before 'u_int'
../xf86drmMode.c: In function 'drmModeRevokeLease':
../xf86drmMode.c:1578: warning: declaration of 'revoke' shadows a global declaration

Happens when building with GCC.
Comment 1 Emmanuel Vadot freebsd_committer freebsd_triage 2020-06-04 09:16:43 UTC 
Created attachment 215216 [details]
patch with upstream MR commit

I've submitted a MR upstream and use that instead.
If it's good for you I'll commit this.
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2020-06-04 09:28:13 UTC 
Yes, it works. Please commit that.
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-06-04 09:36:59 UTC 
A commit references this bug:

Author: manu
Date: Thu Jun  4 09:36:39 UTC 2020
New revision: 537878
URL: https://svnweb.freebsd.org/changeset/ports/537878

Log:
  libdrm: Fix build on GCC based arch

  PR:		246969
  Reported by:	pkubaj

Changes:
  head/graphics/libdrm/Makefile
  head/graphics/libdrm/distinfo
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-06-06 09:23:32 UTC 
A commit references this bug:

Author: manu
Date: Sat Jun  6 09:23:13 UTC 2020
New revision: 538079
URL: https://svnweb.freebsd.org/changeset/ports/538079

Log:
   mesa*: Add platforms option

  Mesa support different platforms, add some options that control which one
  we are enabling and build the -Dplatform meson arg based on that.
  Keep the WAYLAND option for now but if you're using it switch to the
  newly created PLATFORM_WAYLAND.

  PR:		246969
  Approved by:	zeising (x11@ implicit)

Changes:
  head/graphics/mesa-dri/Makefile
  head/graphics/mesa-libs/Makefile