Created attachment 215259 [details] mgba.diff Updated to latest release (0.8.1) "mgba" works without any issues. "mgba-qt" core dumps when I try to load any ROM, however I have the same exactly the same problem with the previous version (0.7.3), so it may be related to my QT install (I never use QT).
lgtm
Forgot to mention, does "games/libretro-mgba" not conflict with this port? Both install the lib; lib/libretro/mgba_libretro.so Freshports; https://www.freshports.org/search.php?query=mgba
(In reply to James Wright from comment #2) Yeah, would be nice to add LIBRETRO_CONFLICTS_INSTALL=libretro-mgba
Created attachment 215268 [details] mgba.diff
Created attachment 215275 [details] mgba.diff
Just done some more testing; "mgba-qt" seems to crash on my system when loading any ROM that is zipped. Unzipping the ROM manually and then loading the unzipped file works fine. "mgba" works no problem with both zipped and unzipped ROMs. Can you check if you have the same behaviour?
Submitted an issue upstream; https://github.com/mgba-emu/mgba/issues/1777
Created attachment 215305 [details] mgba.diff Summary of changes included in mgba.diff; * Updated mgba from 0.7.3 to 0.8.1 * Added DISCORD option to enable/disable Discord RPC support * Added LIBRETRO_CONFLICTS_INSTALL=libretro-mgba * Added patch to fix crash when loading ROM in mgba-qt (taken from upstream fix)
I'm not sure if the discord option would be useful. The Discord client doesn't support FreeBSD. It is possible to port electron apps now, but that one is proprietary so ehhhhhhh.
Ok cool, I'll change the diff to disable Discord in the build :-)
Created attachment 215339 [details] mgba.diff Updated diff to remove Discord option as requested (and set to always off in the build).
I tried to build the port with poudriere using default options and ended up with the following plist error: ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: include/mgba-util/arm-algo.h Error: Orphaned: include/mgba-util/circle-buffer.h Error: Orphaned: include/mgba-util/common.h Error: Orphaned: include/mgba-util/configuration.h Error: Orphaned: include/mgba-util/crc32.h Error: Orphaned: include/mgba-util/elf-read.h Error: Orphaned: include/mgba-util/export.h Error: Orphaned: include/mgba-util/formatting.h Error: Orphaned: include/mgba-util/gui.h Error: Orphaned: include/mgba-util/gui/file-select.h (snip) It appears pkg-plist needs an update.
Created attachment 215467 [details] mgba.diff Updated mgba.diff with regenerated pkg-plist as requested! :-)
A commit references this bug: Author: tagattie Date: Fri Jun 12 10:57:10 UTC 2020 New revision: 538596 URL: https://svnweb.freebsd.org/changeset/ports/538596 Log: - Update to 0.8.1 - Add LIBRETRO_CONFLICTS_INSTALL=libretro-mgba - Add patch to fix crash when loading ROM in mgba-qt (taken from upstream fix) PR: 247007 Submitted by: James Wright <james.wright@digital-chaos.com> Approved by: greg@unrelenting.technology (maintainer), mentors (implicit) Changelog: https://github.com/mgba-emu/mgba/blob/0.8.1/CHANGES Changes: head/emulators/mgba/Makefile head/emulators/mgba/distinfo head/emulators/mgba/files/ head/emulators/mgba/files/patch-src_platform_qt_CoreManager.cpp head/emulators/mgba/pkg-plist
Committed, thanks!