Bug 247037 - x11/alacritty: some keys are not recognized on Wayland
Summary: x11/alacritty: some keys are not recognized on Wayland
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2020-06-06 21:54 UTC by Jan Beich
Modified: 2020-06-11 01:06 UTC (History)
1 user (show)

See Also:


Attachments
fix (10.01 KB, patch)
2020-06-06 21:54 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2020-06-06 21:54:14 UTC
Created attachment 215301 [details]
fix

I have "bind C-] send-prefix" in ~/.tmux.conf. alacritty on Wayland doesn't recognize it. Let's apply proposed upstream fix.

Tested build/runtime inside 11.3 i386 jail.

Steps to reproduce:
- pkg install alacritty libxkbcommon mesa-dri dejavu
- Open alacritty under Sway
- Press Ctrl+V
- Press Ctrl+]

Expected result:
^] is printed

Actual result:
Nothing is printed
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2020-06-09 12:08:26 UTC
Hmm, I cannot reproduce it with the given steps.
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2020-06-10 10:01:20 UTC
Anyway, I have not seen any problems with the patch applied, so feel free
to commit it if it fixes something.
Comment 3 Jan Beich freebsd_committer freebsd_triage 2020-06-10 18:36:08 UTC
(In reply to Tobias Kortkamp from comment #1)
> Hmm, I cannot reproduce it with the given steps.

Likely the steps are specific to keyboard layout. For one, I have

  $ swaymsg 'input * xkb_layout us(dvp)'

where ] key is located where 0 on qwerty is. On "us" (qwerty) layout Ctrl+] works fine as is (without patch) for me as well.
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-06-11 00:25:03 UTC
A commit references this bug:

Author: jbeich
Date: Thu Jun 11 00:24:05 UTC 2020
New revision: 538445
URL: https://svnweb.freebsd.org/changeset/ports/538445

Log:
  x11/alacritty: fix missing keys on Wayland

  For one, this fixes Ctrl+] on us(dvp) layout.

  PR:		247037
  Approved by:	tobik (maintainer)
  Obtained from:	upstream

Changes:
  head/x11/alacritty/Makefile
  head/x11/alacritty/files/
  head/x11/alacritty/files/patch-winit-pr1534