Created attachment 215368 [details] patch for port I'm adjusted openfire port for new compiler. And now I tested last 4.5.2 version with openjdk 8 and 11 versions. Also I tested update from previous version to last. For clean installation update was successfully with embedded and external database, but for my production server I was needed to remove all files from /usr/local/share/java/openfire and /usr/local/etc/openfire. All my settings stores in external database and it was not complicated, but I was need to configure openfire again, that can be a problem for some users. I am also ready to become a maintainer for this port.
Feedback on the patch: - please use relative pathes in the patch, so that we can use svn patch file - PORTEPOCH can not decrease, so keep it at '1' example for the pathes: does not work: --- /usr/ports/net-im/openfire/Makefile.orig 2019-02-06 13:20:08.000000000 +0000 +++ /usr/ports/net-im/openfire/Makefile 2020-05-28 20:49:22.042924000 +0000 works: --- Makefile.orig 2019-02-06 13:20:08.000000000 +0000 +++ Makefile 2020-05-28 20:49:22.042924000 +0000 I'm testbuilding now (but it's late here, so I'll sleep over it).
Ah, first feedback: The most general way to build a port is using poudriere. Which has a fetch-distfiles and a build phase. maven wants to fetch stuff in the build phase, which poudriere does not allow. So the build process needs to be restructured somehow so that it does not fetch in the build phase. For my build log using poudriere see: https://people.freebsd.org/~pi/logs/openfire-v1.txt
Please have a look at: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html especially the https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#testing-poudriere section.
For a discussion on maven ports in general, see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=188110#c37 archivers/snappy-java uses some construct to get this going. Have a look, maybe it helps you for this port as well.
Mkay. Thanx for all this notes. I will try to resolve fetching during building process.
Ok. I have some success with offline compiling. And tested solution in my local network. Tested only with java8, now, but must working with 11 also. If you place anywhere this archive with maven plugins: https://yadi.sk/d/7I1i8gYzeeCHTw and will give me link, then, I will upload new patch.
(In reply to Nikita Druba from comment #6) I'm downloading the file right now. If there's a direct link to download, that would be much better. because otherwise I have to download 130mb on a slow adsl16mbit and upload it again to freefall over the even slower 1mbit/s uplink of said adsl16 8-(
(In reply to Kurt Jaeger from comment #7) So, it's available now at: MASTER_SITES=LOCAL/pi/FreeBSD-openfire-4.5.2-maven-repository.tar.gz
Created attachment 215456 [details] update port with maven repo from freebsd.org update to 4.2.3(current)
New diff in attachment. Tested for java 8 and 11. For any other versions maven can use some other plugins, that doesn't have in repo archive.
testbuilds look fine
Committed, thanks!
A commit references this bug: Author: pi Date: Fri Jun 12 07:12:59 UTC 2020 New revision: 538563 URL: https://svnweb.freebsd.org/changeset/ports/538563 Log: net-im/openfire: update 4.2.3 -> 4.5.2 - submitter becomes maintainer PR: 247090 Submitted by: Nikita Druba <nikita@druba.su> Relnotes: http://download.igniterealtime.org/openfire/docs/latest/changelog.html Changes: head/net-im/openfire/Makefile head/net-im/openfire/distinfo head/net-im/openfire/files/pkg-message.in head/net-im/openfire/pkg-plist
Please note: Adding some changelog URL to the PR helps the committer to compose the commit message 8-}
Ok, thanx! I'll remember about changelog. May be in /usr/ports/UPDATES file need to write something, like: "Sources for using with maven compiler not contains many plugins. Users of openfire must install all needed plugins manually. In some cases is needed reconfiguration. Don't forget doing backup of database and config files." P.S. I think, that for next openfire version I'll need to upload new version of maven repo. For now, I don't have personal ftp or any storage, that use direct links. So, can I directly upload needed files to freefall?
(In reply to Nikita Druba from comment #15) The message is best put into pkg-message 8-} https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#porting-message If you need to provide a new maven repo, lets do it the same way as before: you put it somewhere for me to download, I'll put it on freefall. Access to freefall is not generally available, it's normally only for committers. If you want to become more active in the ports tree etc, then you can easily become a ports committer...