Bug 247226 - databases/postgresql11-server: bad PLIST substitution
Summary: databases/postgresql11-server: bad PLIST substitution
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: pgsql
URL:
Keywords: easy, needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2020-06-13 03:38 UTC by Garrett Wollman
Modified: 2020-06-15 08:12 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (pgsql)
koobs: merge-quarterly?

Attachments
Trivial patch (1.43 KB, patch)
2020-06-13 22:29 UTC, Garrett Wollman 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Garrett Wollman freebsd_committer freebsd_triage 2020-06-13 03:38:44 UTC 
postgresql1[12]-server/pkg-plist-server contains the following entry:

%%LLVM%%lib/postgresql/bitcode/postgres/tcop/%%PG_USER%%.bc

However, the name of this file does not depend on PG_USER; it's always "postgres.bc".  It only works because, by coincidence, PG_USER defaults to "postgres". If PG_USER is overridden in make.conf (as one might need to do, for example, in preparation to upgrade from a version with a different PG_USER default), the package build will fail because the referenced file does not exist.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-06-13 04:52:16 UTC 
Are any other posgtresql ports affected?

Note also the fix for this (as reported) would appear to satisfy either of:

Approved by: portmgr (blanket: just fix it)
Approved by: portmgr (blanket: packaging bugfix)

And a merge quarterly candidate if the quarterly versions are also affected.
Comment 2 Garrett Wollman freebsd_committer freebsd_triage 2020-06-13 22:24:48 UTC 
(In reply to Kubilay Kocak from comment #1)
Only postgresql11-server and postgresql12-server are affected because they are the only ones that include the LLVM-based JIT functionality that the file in question is part of.
Comment 3 Garrett Wollman freebsd_committer freebsd_triage 2020-06-13 22:29:46 UTC 
Created attachment 215530 [details]
Trivial patch
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-06-15 06:57:29 UTC 
A commit references this bug:

Author: girgen
Date: Mon Jun 15 06:56:41 UTC 2020
New revision: 538854
URL: https://svnweb.freebsd.org/changeset/ports/538854

Log:
  Fix bad plist substitution

  PR:		247226
  Reported by:	Garrett Wollman

Changes:
  head/databases/postgresql-jdbc/Makefile
  head/databases/postgresql-jdbc/distinfo
  head/databases/postgresql11-server/pkg-plist-server
  head/databases/postgresql12-server/pkg-plist-server
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-06-15 07:43:33 UTC 
A commit references this bug:

Author: girgen
Date: Mon Jun 15 07:43:25 UTC 2020
New revision: 538855
URL: https://svnweb.freebsd.org/changeset/ports/538855

Log:
  MFH: r538854

  Fix bad plist substitution

  PR:		247226
  Reported by:	Garrett Wollman
  Approved by:	portmgr (blanket: packaging bugfix)

Changes:
_U  branches/2020Q2/
  branches/2020Q2/databases/postgresql11-server/pkg-plist-server
  branches/2020Q2/databases/postgresql12-server/pkg-plist-server
Comment 6 Palle Girgensohn freebsd_committer freebsd_triage 2020-06-15 08:12:37 UTC 
Apologize about the bad commit of postgresql-jdbc. Fixed in 245719.

Apart from that, I committed the fix and merged it to quarterly.

Thanks!