Created attachment 215579 [details] proposed patch - Update to version 1.4 - Change MASTER_SITES to github project page New file: files/patch-darkice.cfg Remove file: files/patch-src_FaacEncoder.cpp
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/156311944
Thanks for the patch Alex! Since you are bumping PORTVERSION, PORTREVISION can be removed completely. Would you update the patch?
Created attachment 215601 [details] patch without PORTVERSION
(In reply to Fernando Apesteguía from comment #2) Sorry, it was my first port updating experience. Updated the patch
Created attachment 215663 [details] darkice-1.4.patch portlint compliant.
Created attachment 215664 [details] Update to 1.4 Fixed portlint error
(In reply to Alex Hemp from comment #6) Good job! Thanks!
^Triage: Added changelog to URL field
Do I need to do something more to make this port changes being accepted?
(In reply to Alex Hemp from comment #9) Just a committer to pick this up :-)
(In reply to Fernando Apesteguía from comment #10) So I basically wait for one ))
Hi there, pkg-message.in states that the service can be started with: %%ETCDIR%%/rc.d/darkice start but that expands to /usr/local/etc/darkice/rc.d/darkice which is not correct. It should probably be: %%PREFIX%%/etc/rc.d/darkice start which expands to (in a normal installation without prefix): /usr/local/etc/rc.d/darkice Would you mind checking? Thanks!
Created attachment 216326 [details] updated patchfile You're absolutely right. I've updated patch file. I'm sorry I missed that, but it was in previous version of port.
(In reply to Alex Hemp from comment #13) No worries, The port builds fine, just one more thing. I copied the sample config to /etc/ and try to run darkice, but got this error: root@12_1i386-default:~ # cp /usr/local/etc/darkice.cfg.sample /usr/local/etc/darkice.cfg root@12_1i386-default:~ # darkice DarkIce 1.4 live audio streamer, http://code.google.com/p/darkice/ Copyright (c) 2000-2007, Tyrell Hungary, http://tyrell.hu/ Copyright (c) 2008-2013, Akos Maroy and Rafael Diniz This is free software, and you are welcome to redistribute it under the terms of The GNU General Public License version 3 or any later version. Using config file: /etc/darkice.cfg DarkIce: DarkIce.cpp:155: no section [general] in config [0] I see that section in the file, would you mind checking this?
It's okay, darkice needs config file to be supplied in command line, so startup script in %%ETCDIR%%/rc.d/darkice has predefined one > : ${darkice_flags="-c ${required_files}"} try > service darkice onestart
Sorry, of course "%%PREFIX%%/etc/rc.d/darkice" script
A commit references this bug: Author: fernape Date: Thu Jul 9 15:41:25 UTC 2020 New revision: 541756 URL: https://svnweb.freebsd.org/changeset/ports/541756 Log: audio/darkice: Update to 1.4 ChangeLog: https://github.com/rafael2k/darkice/blob/master/darkice/trunk/ChangeLog PR: 247274 Submitted by: hempalex@gmail.com Changes: head/audio/darkice/Makefile head/audio/darkice/distinfo head/audio/darkice/files/patch-darkice.cfg head/audio/darkice/files/patch-src_FaacEncoder.cpp head/audio/darkice/files/pkg-message.in
Committed, Thanks for your work!