Created attachment 215756 [details] www/squid: Update to 4.12 Hi, please find the patch attached. Changelog: http://www.squid-cache.org/Versions/v4/changesets/SQUID_4_12.html Poudriere logs: http://freebsd-stable.builder.wilbury.net/data/11_4_RELEASE_GENERIC-default-hvpngw/2020-06-19_00h42m41s/logs/squid-4.12.log http://freebsd-stable.builder.wilbury.net/data/12_STABLE_GENERIC_amd64-default/2020-06-19_01h08m14s/logs/squid-4.12.log http://freebsd-current.builder.wilbury.net/data/13_CURRENT_GENERIC_amd64-default/2020-06-19_00h45m59s/logs/squid-4.12.log
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/157847048
^Triage: Please set the maintainer-approval attachment flag (to ?) and set the requestee field to the e-mail address of the maintainer to ask for maintainer approval. Attachment -> Details -> maintainer-approval [?]
(In reply to Juraj Lutter from comment #0) Thank you very much for the report! I've been testing my own patch this week. Sorry for the delay. I'll review the patch-configure part soon.
Created attachment 216115 [details] port patch - Update to 4.12 - Remove upstreamed patches - Enhance rc script (thanks to t.eichstaedt at gmx.net for ideas!): -- create piddir if missing (/var/run may be a tmpfs) -- don't wait endlessly if squid can't create a pidfile -- define squid_group
(In reply to timp87 from comment #4) "t.eichstaedt at gmx.net" should be changed to "Walter von Entferndt" in the last comment
Comment on attachment 215756 [details] www/squid: Update to 4.12 ^Triage: Obsolete older patch
^Triage: - Feedback provided (maintainer-feedback +) - Bugfix release: MFH: 2020Q3 (blanket: bugfix release)
(In reply to Kubilay Kocak from comment #7) I would love to see that in 2020Q3
(In reply to timp87 from comment #8) All non-feature updates are merge candidates. Please set merge-quarterly flag to ? on future proposed changes that are relevant to ensure those merges take place
(In reply to Kubilay Kocak from comment #9) Ok, thank you
Might want to be aware of an issue w/ Squid-4.12 and Chrome/Chromium-based browsers. IE and Firefox browsers work fine (so far) with 4.12, but Vivaldi and the new Edge fail to connect to any sites. https://github.com/squid-cache/squid/pull/663 https://www.spinics.net/lists/squid/msg92728.html https://www.spinics.net/lists/squid/msg92814.html
Let me review and test. Thanks for bringing this up.
Created attachment 216343 [details] Update to 4.12 and address GREASEd
Tested on - Firefox nightly - Safari - Chromium based Edge Works on all of them. Poudriere log: https://freebsd-stable.builder.wilbury.net/data/12_STABLE_GENERIC_amd64-default-nextcloud/2020-07-09_20h15m40s/logs/squid-4.12.log
And a testport results: https://freebsd-stable.builder.wilbury.net/data/12_STABLE_GENERIC_amd64-default-nextcloud/2020-07-09_21h04m32s/logs/squid-4.12.log
Created attachment 216412 [details] port patch new - Update to 4.12 - Remove upstreamed patches - Enhance rc script (thanks to Walter von Entferndt for ideas!): -- create piddir if missing (/var/run may be a tmpfs) -- don't wait endlessly if squid can't create a pidfile -- define squid_group - address GREASEd (thanks to Joshua Kinard and Juraj Lutter!) Juraj Lutter, I have recreated because your version has trimmed a part of configure patch with IPF support.
A commit references this bug: Author: garga Date: Mon Jul 27 14:50:16 UTC 2020 New revision: 543526 URL: https://svnweb.freebsd.org/changeset/ports/543526 Log: www/squid: Update to 4.12 among other changes - Update to 4.12 - Remove upstreamed patches - Enhance rc script (thanks to Walter von Entferndt for ideas!): -- create piddir if missing (/var/run may be a tmpfs) -- don't wait endlessly if squid can't create a pidfile -- define squid_group - address GREASEd (thanks to Joshua Kinard and Juraj Lutter!) PR: 247397 Submitted by: Juraj Lutter <juraj@lutter.sk> Reworked by: maintainer Approved by: maintainer MFH: 2020Q3 (bug-fix release) Sponsored by: Rubicon Communications, LLC (Netgate) Changes: head/www/squid/Makefile head/www/squid/distinfo head/www/squid/files/patch-configure head/www/squid/files/patch-src_acl_external_eDirectory__userip_ext__edirectory__userip__acl.cc head/www/squid/files/patch-src_acl_external_kerberos__ldap__group_support__krb5.cc head/www/squid/files/patch-src_security_Handshake.cc head/www/squid/files/squid.in
A commit references this bug: Author: garga Date: Tue Jul 28 11:05:03 UTC 2020 New revision: 543590 URL: https://svnweb.freebsd.org/changeset/ports/543590 Log: MFH: r543526 www/squid: Update to 4.12 among other changes - Update to 4.12 - Remove upstreamed patches - Enhance rc script (thanks to Walter von Entferndt for ideas!): -- create piddir if missing (/var/run may be a tmpfs) -- don't wait endlessly if squid can't create a pidfile -- define squid_group - address GREASEd (thanks to Joshua Kinard and Juraj Lutter!) PR: 247397 Submitted by: Juraj Lutter <juraj@lutter.sk> Reworked by: maintainer Approved by: maintainer Sponsored by: Rubicon Communications, LLC (Netgate) Approved by: ports-secteam (joneum) Changes: _U branches/2020Q3/ branches/2020Q3/www/squid/Makefile branches/2020Q3/www/squid/distinfo branches/2020Q3/www/squid/files/patch-configure branches/2020Q3/www/squid/files/patch-src_acl_external_eDirectory__userip_ext__edirectory__userip__acl.cc branches/2020Q3/www/squid/files/patch-src_acl_external_kerberos__ldap__group_support__krb5.cc branches/2020Q3/www/squid/files/patch-src_security_Handshake.cc branches/2020Q3/www/squid/files/squid.in
*** Bug 247247 has been marked as a duplicate of this bug. ***