Bug 247697 - textproc/p5-Perl-Critic broken with lang/perl5.32
Summary: textproc/p5-Perl-Critic broken with lang/perl5.32
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Mathieu Arnold
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-01 19:37 UTC by Mike Andrews
Modified: 2020-08-27 20:43 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (mat)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Andrews 2020-07-01 19:37:31 UTC
Perl::Critic (which is a bit out of date) doesn't work with Perl 5.32 due to a missing dependency -- which in turn is likely due to a module being removed from the core Perl distribution in 5.32:

Can't locate Pod/PlainText.pm in @INC (you may need to install the Pod::PlainText module) (@INC contains: /usr/local/lib/perl5/site_perl/mach/5.32 /usr/local/lib/perl5/site_perl /usr/local/lib/perl5/5.32/mach /usr/local/lib/perl5/5.32) at /usr/local/lib/perl5/site_perl/Perl/Critic/Utils/POD.pm line 10.

There is no port for p5-Pod-PlainText.

This is likely an issue for upstream since Pod::PlainText is deprecated.
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-08-26 13:32:44 UTC
A commit references this bug:

Author: mat
Date: Wed Aug 26 13:32:25 UTC 2020
New revision: 546282
URL: https://svnweb.freebsd.org/changeset/ports/546282

Log:
  Add missing dependency.

  PR:		247697
  Reported by:	Mike Andrews

Changes:
  head/textproc/p5-Perl-Critic/Makefile
Comment 2 Mike Andrews 2020-08-27 13:49:01 UTC
(In reply to commit-hook from comment #1)

Unfortunately that didn't fix the issue.  That patch adds Pod::Parser as a dependency, but that doesn't help when Perl::Critic is explicitly trying to pull in Pod::PlainText instead.
Comment 3 Mathieu Arnold freebsd_committer freebsd_triage 2020-08-27 20:43:33 UTC
# pkg info -l p5-Pod-Parser|grep 'Pod.*PlainText'
        /usr/local/lib/perl5/site_perl/Pod/PlainText.pm
        /usr/local/lib/perl5/site_perl/man/man3/Pod::PlainText.3.gz

Unless there is something very very subtle about what you are saying, I fail to understand what the problem is.