Bug 247781 - net-mgmt/networkmgr: Update to 4.1
Summary: net-mgmt/networkmgr: Update to 4.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Eric Turgeon
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2020-07-05 15:10 UTC by Miguel Gocobachi
Modified: 2020-07-06 23:33 UTC (History)
0 users

See Also:
koobs: maintainer-feedback+

Attachments
version up (1.22 KB, patch)
2020-07-05 15:10 UTC, Miguel Gocobachi 		no flags Details | Diff
with sudo a no doas (2.57 KB, patch)
2020-07-05 17:20 UTC, Miguel Gocobachi 		no flags Details | Diff
version up (2.66 KB, patch)
2020-07-05 22:27 UTC, Miguel Gocobachi 		no flags Details | Diff
version up (3.13 KB, patch)
2020-07-06 15:50 UTC, Miguel Gocobachi 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gocobachi 2020-07-05 15:10:44 UTC 
Created attachment 216218 [details]
version up

update version from 3.6 to 4.1
Comment 1 Eric Turgeon freebsd_committer freebsd_triage 2020-07-05 17:11:12 UTC 
The reason I have not updated the NetworkMgr to the latest because it use sudo now and I am not sure it will be acepted to have /usr/local/etc/sudoers.d/networkmgr.

Doas support was remove in the latest changes and I se that your patch does not refect the changes that was done to NetworkMgr.

If someone can confirm that NetworkMgr can install /usr/local/etc/sudoers.d/networkmgr I will update the port.
Comment 2 Miguel Gocobachi 2020-07-05 17:14:33 UTC 
(In reply to Eric Turgeon from comment #1)

yeah I just noticed a couple minutes ago about those changes. Maybe it should put on hold I guess until further confirmation.
Comment 3 Miguel Gocobachi 2020-07-05 17:20:18 UTC 
Created attachment 216224 [details]
with sudo a no doas

this is the update removing doaes and adding sudo as dependency, but again. I totally understood your point Eric.
Comment 4 Miguel Gocobachi 2020-07-05 22:27:22 UTC 
Created attachment 216237 [details]
version up

forgot to remove the sub_files for the pkg-message
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2020-07-06 04:34:41 UTC 
^Triage: Feedback provided (+), set maintainer-feedback accordingly. @Eric If you meant to not accept the proposed patch, use maintainer-approval attachment flag (set to -)

I would also obsolete the patch so its not accidentally committed
Comment 6 Eric Turgeon freebsd_committer freebsd_triage 2020-07-06 12:38:04 UTC 
(In reply to Miguel Gocobachi from comment #4)
you forgot to update the pkg-plist for the there is a new file installed by NetworkMgr.
Comment 7 Miguel Gocobachi 2020-07-06 15:50:21 UTC 
Created attachment 216257 [details]
version up

pkg-plist updated and INSTALLS_ICONS added
Comment 8 commit-hook freebsd_committer freebsd_triage 2020-07-06 23:31:11 UTC 
A commit references this bug:

Author: ericbsd
Date: Mon Jul  6 23:30:44 UTC 2020
New revision: 541374
URL: https://svnweb.freebsd.org/changeset/ports/541374

Log:
  update net-mgmt/networkmgr to 4.1

  PR:		247781
  Submitted by:	Miguel Gocobachi

Changes:
  head/net-mgmt/networkmgr/Makefile
  head/net-mgmt/networkmgr/distinfo
  head/net-mgmt/networkmgr/files/
  head/net-mgmt/networkmgr/pkg-plist