Bug 247856 - sysutils/iocage: fetch doesn't work on i386
Summary: sysutils/iocage: fetch doesn't work on i386
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: i386 Any
: --- Affects Only Me
Assignee: Michael Gmelin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-08 20:35 UTC by Vincent Bentley
Modified: 2020-07-19 11:57 UTC (History)
1 user (show)

See Also:

Attachments
Patch to fix an installed iocage on i386 (1.21 KB, patch)
2020-07-08 20:35 UTC, Vincent Bentley 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Bentley 2020-07-08 20:35:47 UTC 
Created attachment 216328 [details]
Patch to fix an installed iocage on i386

On a 32-bit X86 jail host, iocage fetch fails because it is looking for lib32.txz in an i386 repo. The lib32.txz archive is only present in the amd64 repo because it is not required for i386 machines.

I found the bug in /usr/local/lib/python3.7/site-packages/iocage_lib/iocage.py

The attached patch fixes an already installed iocage. I sent email to upstream but have not received a reply yet.
Comment 1 Vincent Bentley 2020-07-08 20:38:30 UTC 
The patch also fixes missing lib32 support on amd64 jails.
Comment 2 Li-Wen Hsu freebsd_committer freebsd_triage 2020-07-08 20:40:24 UTC 
Over to the maintainer.
Comment 3 Michael Gmelin freebsd_committer freebsd_triage 2020-07-19 11:22:13 UTC 
Hi Vincent,

Thanks for submitting. Looking at your patch, in the second part it seems like you confused "arm64" with "amd64" (happened to me first as well). Installing lib32.txz probably doesn't make sense on arm64.

Anyway, good news is that upstream fixed the problem on i386, I'll pull in the fix to the port, thanks for reporting!

Best,
Michael
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-07-19 11:54:51 UTC 
A commit references this bug:

Author: grembo
Date: Sun Jul 19 11:54:48 UTC 2020
New revision: 542567
URL: https://svnweb.freebsd.org/changeset/ports/542567

Log:
  Fix `iocage fetch' on i386.

  While there, switch to fetching all patches directly from github.

  PR:		247856
  Reported by:	Vincent Bentley

Changes:
  head/sysutils/iocage/Makefile
  head/sysutils/iocage/distinfo
  head/sysutils/iocage/files/patch-iocage__lib_ioc__common.py
  head/sysutils/iocage/files/patch-iocage__lib_ioc__fetch.py
  head/sysutils/iocage/files/patch-iocage__lib_ioc__json.py
  head/sysutils/iocage/files/patch-iocage__lib_ioc__start.py