Bug 248384 - devel/llvm10: unbreak OPENMP
Summary: devel/llvm10: unbreak OPENMP
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Brooks Davis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-31 11:38 UTC by Val Packett
Modified: 2020-08-05 23:09 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (brooks)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Val Packett 2020-07-31 11:38:13 UTC 
OPENMP llvm10 doesn't compile because of a typo that was fixed in llvm11:

https://github.com/llvm/llvm-project/commit/ea99c09963488130ec0a61ef39df3fd0fcecad3c#diff-6cdf4fa5bc62fbff781fbaba8e5fd806L289

Probably a good idea to backport the patch.
Comment 1 Brooks Davis freebsd_committer freebsd_triage 2020-07-31 23:38:41 UTC 
I'm confused.  The stray `<` doesn't appear in the checked out source and in fact that commit has the llvmorg-11.0.0-rc1 tag.
Comment 2 Brooks Davis freebsd_committer freebsd_triage 2020-07-31 23:39:28 UTC 
Oh, sorry, it's been a long day.  You want this fixed in llvm10.
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-08-05 22:14:41 UTC 
A commit references this bug:

Author: brooks
Date: Wed Aug  5 22:14:17 UTC 2020
New revision: 544246
URL: https://svnweb.freebsd.org/changeset/ports/544246

Log:
  Minor fixes.

  Unbreak OPENMP in some cases.

  Fix C++ library selection for some target values.

  PR:		248384, 248386
  Submitted by:	Greg V
  Differential Revision:	https://reviews.freebsd.org/D24420

Changes:
  head/devel/llvm10/Makefile
  head/devel/llvm10/files/clang/patch-D77776
  head/devel/llvm10/files/openmp/
  head/devel/llvm10/files/openmp/patch-ea99c09