Bug 248431 - lang/smlnj: Update to 110.98, unbreak build with Clang >= 10
Summary: lang/smlnj: Update to 110.98, unbreak build with Clang >= 10
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-08-02 12:48 UTC by Johannes 5
Modified: 2020-08-02 13:32 UTC (History)
1 user (show)

See Also:

Attachments
Update lang/smlnj to 110.98, unbreak when Clang >= 10 (27.37 KB, patch)
2020-08-02 12:48 UTC, Johannes 5 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes 5 2020-08-02 12:48:06 UTC 
Created attachment 216956 [details]
Update lang/smlnj to 110.98, unbreak when Clang >= 10

The attached patch to lang/smlnj should be identical to

	<ftp://wrap7.free.de/pub/patch/smlnj.patch.20200729>
	MD5 (smlnj.patch.20200729) = 5622349b825b10668b056a1481580626

and does the following:

- Update to SML/NJ 110.98, upstream release notes: [1,2].
- Unbreak the build when the compiler is Clang >= 10,
  which was reported and discussed in PR 247421.

The current patch (smlnj.patch.20200729) contains the workaround from
PR 247421. So if the current patch will be accepted, that should close
PR 247421 as well.

Output from poudriere testport on amd64 and i386 is available: [3].

Thanks for considering this PR!
Johannes

[1] <http://www.smlnj.org/dist/working/110.97/110.97-README.html>
[2] <http://www.smlnj.org/dist/working/110.98/110.98-README.html>
[3] <http://mesh-j-3.free.de/poudriere/smlnj/110.98/>
Comment 1 Automation User 2020-08-02 13:07:55 UTC 
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/173435206
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-08-02 13:30:57 UTC 
A commit references this bug:

Author: swills
Date: Sun Aug  2 13:30:52 UTC 2020
New revision: 543956
URL: https://svnweb.freebsd.org/changeset/ports/543956

Log:
  lang/smlnj: Update to 110.98, unbreak build with Clang >= 10

  PR:		248431
  Submitted by:	Johannes 5 <joemann@beefree.free.de> (maintainer)

Changes:
  head/lang/smlnj/Makefile
  head/lang/smlnj/distinfo
  head/lang/smlnj/files/do-patch-asdl_config.sh
  head/lang/smlnj/files/do-patch-asdl_config_check__smlnj__heap__suffix.m4
  head/lang/smlnj/files/do-patch-asdl_src_asdlgen_Makefile.in
  head/lang/smlnj/files/do-patch-base_runtime_objs_mk.amd64-freebsd
  head/lang/smlnj/files/do-patch-base_runtime_objs_mk.x86-freebsd
  head/lang/smlnj/files/do-patch-base_system_Basis_Implementation_date.sml
  head/lang/smlnj/files/do-patch-smlnj-lib_JSON_json-parser.sml
  head/lang/smlnj/files/do-patch-smlnj-lib_JSON_json-stream-printer.sml
  head/lang/smlnj/files/patch-config_install.sh
  head/lang/smlnj/pkg-plist
Comment 3 Steve Wills freebsd_committer freebsd_triage 2020-08-02 13:32:18 UTC 
Committed. BTW, you should try to send your changes upstream if you haven't already. Thanks for the update!