Bug 248446 - databases/sqlite3: Change candidates of OPTIONS_RADIO_RL
Summary: databases/sqlite3: Change candidates of OPTIONS_RADIO_RL
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks: 248428 248459
  Show dependency tree / graph
 
Reported: 2020-08-03 09:31 UTC by Yasuhiro Kimura
Modified: 2020-08-17 11:57 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (pavelivolkov)

Attachments
Patch file (988 bytes, patch)
2020-08-03 09:31 UTC, Yasuhiro Kimura 		no flags Details | Diff
Patch for READLINE option using CONFIGURE_ENABLE helper (983 bytes, patch)
2020-08-04 11:03 UTC, Guido Falsi 		no flags Details | Diff
patch (1.56 KB, patch)
2020-08-08 12:44 UTC, Pavel Volkov 		pavelivolkov: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2020-08-03 09:31:02 UTC 
Created attachment 216984 [details]
Patch file

Since no supported FreeBSD version has libreadline.so in base system, there is no difference between READLINES and READLINEP. So replace them with single READLINE option.
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2020-08-03 12:56:21 UTC 
(In reply to Yasuhiro KIMURA from comment #0)

While it is true no supported FreeBSD version has libreadline in base anymore, the readline USES still has support for that, so it makes sense for the port to leverage that, so the port can still work also on older version, without really harming anyone.

Anyway my comment is not a strong objection to this change, but I don't think there is a reason to reduce support for older FreeBSD version when there is no real advantage.


BTW since your patch removes the double readline option, the CONFIGURE_ENABLE helper can be used:

READLINE_CONFIGURE_ENABLE= readline
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2020-08-04 11:03:51 UTC 
Created attachment 217000 [details]
Patch for READLINE option using CONFIGURE_ENABLE helper

I'm sending an updated patch using CONFIGURE_ENABLE helper in place of CONFIGURE_ON as I suggested in comment #1
Comment 3 Pavel Volkov 2020-08-08 12:44:19 UTC 
Created attachment 217094 [details]
patch

The diff file changed to last revision. From the "(revision 544163)" to "(revision 544349)".
Changed the PORTREVISION variable.
Removed unneeded LIBEDIT_DESC and "USES= ncurses".
In the target "post-install" added list for check used shared libraries.
Comment 4 Jochen Neumeister freebsd_committer freebsd_triage 2020-08-14 10:52:57 UTC 
(In reply to Pavel Volkov from comment #3)

Thx Pavel. Thix fix my error in poudriere. Is your Patch ready to landed? (I will take it)
Comment 5 Pavel Volkov 2020-08-16 12:13:48 UTC 
(In reply to Jochen Neumeister from comment #4)

Hello.
Yes, you may used this patch file.

This is a more practical.
"USES=readline" automatically check and switch library to a ports or to a system realization.
"USES=libedit" work only with a ports realization.
libedit from the system, in current imported version, don't work with unicode characters and don't recommended for used (maybe). Don't passes check "Mk/Script/qa.sh", baselibs function.
Comment 6 commit-hook freebsd_committer freebsd_triage 2020-08-17 11:56:50 UTC 
A commit references this bug:

Author: joneum
Date: Mon Aug 17 11:56:04 UTC 2020
New revision: 545157
URL: https://svnweb.freebsd.org/changeset/ports/545157

Log:
  databases/sqlite3: Change candidates of OPTIONS_RADIO_RL

  Removed unneeded LIBEDIT_DESC and "USES= ncurses".
  In the target "post-install" added list for check used shared libraries.

  PR:		248446
  Submitted by:	maintainer
  Sponsored by:	Netzkommune GmbH

Changes:
  head/databases/sqlite3/Makefile