Bug 248665 - audio/libsndfile: Update to 1.0.29
Summary: audio/libsndfile: Update to 1.0.29
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL: https://github.com/erikd/libsndfile/b...
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2020-08-15 06:37 UTC by Daniel Engberg
Modified: 2020-09-10 10:52 UTC (History)
3 users (show)

See Also:
tcberner: maintainer-feedback+
riggs: merge-quarterly+

Attachments
Patch for libsndfile (1.07 KB, patch)
2020-08-15 06:37 UTC, Daniel Engberg 		no flags Details | Diff
Patch for libsndfile v2 (1.35 KB, patch)
2020-08-15 07:55 UTC, Daniel Engberg 		no flags Details | Diff
Patch for libsndfile v3 (2.22 KB, patch)
2020-08-23 20:18 UTC, Daniel Engberg 		no flags Details | Diff
Patch for libsndfile v4 (3.38 KB, patch)
2020-08-25 10:34 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2020-08-15 06:37:11 UTC 
Created attachment 217222 [details]
Patch for libsndfile

Update to 1.0.29

Tested on FreeBSD 13.0-CURRENT r361421 (amd64)
"make test" OK with and without external libs
Poudriere testport OK 12.1-RELEASE (amd64)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2020-08-15 06:40:19 UTC 
This is just a few commits ahead so I don't think we need to request an exp-run again.
https://github.com/erikd/libsndfile/compare/2ccb23f...v1.0.29
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2020-08-15 06:44:08 UTC 
@Reporter Are all the security issues mentioned in the 1.0.29 already accounted for in existing port versions (including security/vuxml) ?
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2020-08-15 06:46:59 UTC 
@Reporter Also, are these relevant for, or the same as (or a fork of), audio/linux-c7-libsndfile, currently at 1.0.25 (upstream latest 1.0.28)
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2020-08-15 06:48:35 UTC 
(In reply to Kubilay Kocak from comment #3)

Judging by the link to mega-nerd.com/libsndfile/ on github.com/erikd/libsndfile/ it appears to be the case
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2020-08-15 06:52:09 UTC 
Yes, however CVE-2018-19661 and CVE-2018-19662 aren't listed in vuxml.
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2020-08-15 07:55:35 UTC 
Created attachment 217223 [details]
Patch for libsndfile v2

Add custom TEST_DESC to be more verbose about limitations with TEST option
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=248533

Suggested by tcberner@ and Daniel O'Connor
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2020-08-23 20:18:37 UTC 
Created attachment 217465 [details]
Patch for libsndfile v3

Use release archive
Don't pull in sqlite(3) and speex
Comment 8 Tobias C. Berner freebsd_committer freebsd_triage 2020-08-23 20:33:23 UTC 
Moin moin 

I'm not a big fan of sedding out static lines. The REINPLACE_CMD should be patches. 
But even better, as it uses cmake's find_package, you can simply pass add 
-DCMAKE_DISABLE_FIND_PACKAGE_Speec:BOOL=True 
to CMAKE_ARGS, without any patchery. [1]


mfg Tobias 

[1] https://cmake.org/cmake/help/latest/variable/CMAKE_DISABLE_FIND_PACKAGE_PackageName.html#variable:CMAKE_DISABLE_FIND_PACKAGE_%3CPackageName%3E
Comment 9 Daniel Engberg freebsd_committer freebsd_triage 2020-08-25 10:34:29 UTC 
Created attachment 217518 [details]
Patch for libsndfile v4

Use CMAKE_DISABLE_FIND_PACKAGE per suggestion of tcberner@

Remove patch for ALSA and Sndio
Comment 10 Daniel Engberg freebsd_committer freebsd_triage 2020-09-09 16:32:49 UTC 
riggs@
Does this need any changes?
Comment 11 commit-hook freebsd_committer freebsd_triage 2020-09-10 10:09:58 UTC 
A commit references this bug:

Author: riggs
Date: Thu Sep 10 10:08:59 UTC 2020
New revision: 548196
URL: https://svnweb.freebsd.org/changeset/ports/548196

Log:
  Update to upstream release 1.0.29

  PR:		248665
  Submitted by:	daniel.engberg.lists@pyret.net
  Reviewed by:	tcberner
  MFH:		2020Q3 (hat: ports-secteam)

Changes:
  head/audio/libsndfile/Makefile
  head/audio/libsndfile/distinfo
  head/audio/libsndfile/files/patch-CMakeLists.txt
  head/audio/libsndfile/files/patch-cmake_SndFileChecks.cmake
Comment 12 commit-hook freebsd_committer freebsd_triage 2020-09-10 10:52:06 UTC 
A commit references this bug:

Author: riggs
Date: Thu Sep 10 10:51:41 UTC 2020
New revision: 548199
URL: https://svnweb.freebsd.org/changeset/ports/548199

Log:
  MFH: r548196

  Update to upstream release 1.0.29

  PR:		248665
  Submitted by:	daniel.engberg.lists@pyret.net
  Reviewed by:	tcberner

  Approved by:	ports-secteam (riggs)

Changes:
_U  branches/2020Q3/
  branches/2020Q3/audio/libsndfile/Makefile
  branches/2020Q3/audio/libsndfile/distinfo
  branches/2020Q3/audio/libsndfile/files/patch-CMakeLists.txt
  branches/2020Q3/audio/libsndfile/files/patch-cmake_SndFileChecks.cmake
Comment 13 Thomas Zander freebsd_committer freebsd_triage 2020-09-10 10:52:46 UTC 
Committed, thanks :-)