Created attachment 217478 [details] version change owfs 3.2p4 have been released, which among other things fixes a FreeBSD build bug. Attached patch makes the port use the latest version (almost only version number changes in port)
^Triage: - [tags] in issue Titles are deprecated - If there is a changelog or release notes URL available for this version, please add it to the URL field
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/181297861
Hi, Please use upstream release archive instead of GitHub (5.4.3 in Porter's Handbook). https://github.com/owfs/owfs/releases/tag/v3.2p4
Sorry, I'm not following. I thought USE_GITHUB with no custom GH_TAGNAME would use the GH release .tar.gz. Can you please clarify?
Hi, No, it's doesn't revert to downloading "assets" https://svnweb.freebsd.org/ports/head/Mk/bsd.sites.mk?revision=543005&view=markup#l345
Would the following pseudo-patch be correct? - DISTVERSIONPREFIX= v - USE_GITHUB= yes .. + MASTER_SITES = https://github.com/owfs/owfs/releases/download/v${PORTVERSION}/
According to example 5.4 you should use DISTVERSION as far as I can tell, looks good otherwise. https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-naming.html
The 'p' in this case indicates patch version 4, not "pre". My understanding from 5.4 is to use DISTVERSION if I want 3.2p4 to be ordered before 3.2, but that is not the case here, 3.2p4 comes after 3.2 and 3.2p3.
I see, in that case PORTVERSION is the correct variable.
Created attachment 217815 [details] Updates to 2.3p4 and removes USE_GITHUB Updated patch attached
I looked at this a bit closer, owtraffic is no longer available as a configure switch and should be removed You can drop autoreconf and gmake from USES= (compiles fine on -CURRENT without) MASTER_SITES variable should be directly under CATEGORIES variable. Usage of uthash should be properly specified Best regards, Daniel
Created attachment 218454 [details] Update to 3.2p4 & distfile + remove python, owtraffic options A new patch attached (against existing port): * Update 3.2p3 -> 3.2p4 * Change from USE_GITHUB to MASTER_SITES * Remove OWFS Python bindings, as python2.7 is no longer supported in FreeBSD and owfs python binding does not build with anything else. It is deprecated in favour for pyownet or similar (see https://github.com/owfs/owfs/issues/75 for more details) * Remove owtraffic as it is now builtin. * Add uthash build dependency (header-only) I was not able to remove USES=gmake however, if I did that a bunch of manpages did not get included (which poudriere testport detected and failed). portlint -A does not complain on anything now, so hopefully Makefile is in order
pkg-fallout builder keeps spamming me every day with two mails about builds failing, things fixed in 3.2p4. Also, the threat of removal due to python 2.7 dep: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=249589 If anyone could update the port I'd appreciate it.
A commit references this bug: Author: kevans Date: Fri Dec 4 14:28:55 UTC 2020 New revision: 556984 URL: https://svnweb.freebsd.org/changeset/ports/556984 Log: comms/owfs: update to 3.2p4 owfs 3.2p4 have been released, which among other things fixes a FreeBSD build bug. * Update 3.2p3 -> 3.2p4 * Change from USE_GITHUB to MASTER_SITES * Remove OWFS Python bindings, as python2.7 is no longer supported in FreeBSD and owfs python binding does not build with anything else. It is deprecated in favour for pyownet or similar (see https://github.com/owfs/owfs/issues/75 for more details) * Remove owtraffic as it is now builtin. * Add uthash build dependency (header-only) PR: 248868 Approved by: maintainer MFH: 2020Q4 (blanket: build fix) Changes: head/comms/owfs/Makefile head/comms/owfs/Makefile.options head/comms/owfs/distinfo head/comms/owfs/pkg-plist
A commit references this bug: Author: kevans Date: Fri Dec 4 14:29:37 UTC 2020 New revision: 556985 URL: https://svnweb.freebsd.org/changeset/ports/556985 Log: MFH: r556984 comms/owfs: update to 3.2p4 owfs 3.2p4 have been released, which among other things fixes a FreeBSD build bug. * Update 3.2p3 -> 3.2p4 * Change from USE_GITHUB to MASTER_SITES * Remove OWFS Python bindings, as python2.7 is no longer supported in FreeBSD and owfs python binding does not build with anything else. It is deprecated in favour for pyownet or similar (see https://github.com/owfs/owfs/issues/75 for more details) * Remove owtraffic as it is now builtin. * Add uthash build dependency (header-only) PR: 248868 Approved by: maintainer Changes: _U branches/2020Q4/ branches/2020Q4/comms/owfs/Makefile branches/2020Q4/comms/owfs/Makefile.options branches/2020Q4/comms/owfs/distinfo branches/2020Q4/comms/owfs/pkg-plist