Bug 248897 - devel/phabricator don't exclude php7.4
Summary: devel/phabricator don't exclude php7.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Michael Gmelin
URL:
Keywords:
: 248898 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-08-25 01:43 UTC by ari
Modified: 2020-08-26 16:21 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (grembo)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ari 2020-08-25 01:43:01 UTC 
PHP74 has been excluded from this port by an automated script:

https://svnweb.freebsd.org/ports?view=revision&revision=512557


However it works perfectly fine with 7.4.
Comment 1 Li-Wen Hsu freebsd_committer freebsd_triage 2020-08-25 09:16:46 UTC 
*** Bug 248898 has been marked as a duplicate of this bug. ***
Comment 2 Michael Gmelin freebsd_committer freebsd_triage 2020-08-26 16:17:40 UTC 
(In reply to ari from comment #0)

Thanks for bringing this to my attention, I didn't notice this happened.

I tested building it using the php74 flavor with poudriere (which worked ok) and also ran a small test installation to see if there are any practical (easy to spot) problems. All seems to look fine.

Therefore, whatever the reason was for it to fail/be marked as "ignore" almost a year ago is probably gone, so I'll bring php74 back for it.
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-08-26 16:21:11 UTC 
A commit references this bug:

Author: grembo
Date: Wed Aug 26 16:20:10 UTC 2020
New revision: 546293
URL: https://svnweb.freebsd.org/changeset/ports/546293

Log:
  Allow building devel/phabricator@php74

  PR:		248897
  Reported by:	ari@ish.com.au

Changes:
  head/devel/phabricator/Makefile