Created attachment 217874 [details] diff for the port, generated as per porters handbook, chapter 3.6 A modern PGP implementation written in rust. This is the cryptographic basis of the pretty easy privacy stack (see https://pep.security ) I'm trying to bring to FreeBSD. Many thanks to Mikael, who helped out a lot in making this port.
Created attachment 217901 [details] fix for security/sequoia
Created attachment 217902 [details] patch for security/py-sequoia
Hi: I made two patches for sequoia. 1: fix some styles of sequoia. 2: split python binding to py-sequoia. please help to review, thanks,
Sorry for the delay – took me a bit to figure out how to use the patch files and then make time and disk space to actually test building. Far as I can tell most everything is in order, tho I can't rightly claim that to mean much as I'm still new to the whole porting thing. The only issue I see is that the py-sequoia port doesn't strip _sequoia.abi3.so. The path on my particular system looks like this: work-py37/sequoia-383133f6be990237044900a4df676488bf8dd71e-383133f6be990237044900a4df676488bf8dd71e/ffi/lang/python/build/lib.freebsd-12.1-RELEASE-p8-amd64-3.7/_sequoia.abi3.so I fixed it locally by adding this to py-sequoia/Makefile: --- UNAME_R != uname -r post-build: ${STRIP_CMD} ${WRKSRC}/build/lib.freebsd-${UNAME_R}-${ARCH}-${PYTHON_VER}/_sequoia.abi3.so --- I'm sure there's some way to avoid setting an extra variable, but for the life of me can't remember what that looked like…
Hi: That's fine with py-sequoia, I will use a better way to strip its _sequoia.abi3.so. thanks for your review.
A commit references this bug: Author: vanilla Date: Sun Sep 20 02:13:28 UTC 2020 New revision: 549082 URL: https://svnweb.freebsd.org/changeset/ports/549082 Log: Add sequoia 0.19.0, modern PGP implementation, written in rust. PR: 249238 Submitted by: phryk-ports@wzff.de Changes: head/security/Makefile head/security/sequoia/ head/security/sequoia/Makefile head/security/sequoia/distinfo head/security/sequoia/files/ head/security/sequoia/files/patch-Makefile head/security/sequoia/files/patch-ffi_Makefile head/security/sequoia/files/patch-openpgp-ffi_Makefile head/security/sequoia/files/patch-sop_Makefile head/security/sequoia/files/patch-sqv_Makefile head/security/sequoia/files/patch-store_Makefile head/security/sequoia/files/patch-tool_Makefile head/security/sequoia/files/sequoia-openpgp.pc.in head/security/sequoia/files/sequoia.pc.in head/security/sequoia/pkg-descr head/security/sequoia/pkg-plist
A commit references this bug: Author: vanilla Date: Sun Sep 20 02:13:56 UTC 2020 New revision: 549083 URL: https://svnweb.freebsd.org/changeset/ports/549083 Log: Add py-sequoia 0.19.0, python binding of sequoia. PR: 249238 Submitted by: phryk-ports@wzff.de Changes: head/security/Makefile head/security/py-sequoia/ head/security/py-sequoia/Makefile head/security/py-sequoia/distinfo head/security/py-sequoia/files/ head/security/py-sequoia/files/patch-Makefile head/security/py-sequoia/files/patch-setup.py head/security/py-sequoia/pkg-descr
Committed, thanks.
(In reply to Vanilla I. Shu from comment #8) And thanks to you, too! I would not have known how to split the python bindings into their own port. :)