Bug 249541 - sysutils/xen-tools: unbreak package with python!=3.7
Summary: sysutils/xen-tools: unbreak package with python!=3.7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Dima Panov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-23 05:29 UTC by Dima Panov
Modified: 2020-09-23 16:13 UTC (History)
0 users

See Also:
fluffy: maintainer-feedback+

Attachments
sysutils/xen-tools: unbreak package with python!=3.7 (1.59 KB, patch)
2020-09-23 05:29 UTC, Dima Panov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dima Panov freebsd_committer freebsd_triage 2020-09-23 05:29:22 UTC 
Created attachment 218202 [details]
sysutils/xen-tools: unbreak package with python!=3.7

unbreak package with python!=3.7
switch to use py3.6+ only
use binary_alias for python3
Comment 1 Roger Pau Monné freebsd_committer freebsd_triage 2020-09-23 09:34:55 UTC 
(In reply to Dima Panov from comment #0)
LGTM, isn't it fine to just pick whatever alias there's in the system for python3? I guess it's possible there's no alias for python3 at all, even when a python 3+ package has been installed?
Comment 2 Dima Panov freebsd_committer freebsd_triage 2020-09-23 12:31:20 UTC 
(In reply to Roger Pau Monné from comment #1)
by default ports not provided symlink for python3 name, so binary_alias is the best and simply way to point scripts to required versioned binary
Comment 3 Roger Pau Monné freebsd_committer freebsd_triage 2020-09-23 13:02:45 UTC 
(In reply to Dima Panov from comment #2)
OK, when installing a binary package will then the python package used for compilation also be installed when xen-tools is installed if the user has a different phython 3 package than the one used during build?
Comment 4 Dima Panov freebsd_committer freebsd_triage 2020-09-23 13:11:18 UTC 
(In reply to Roger Pau Monné from comment #3)
package will pull same python3.x dependency which was used to build, co-exist is allowed by versioned suffixes of any python tools

binary_alias helps to build only, allows skip patch everything which not required in runtime. 
runtime scripts should be patched via shebang hook anyway
Comment 5 Roger Pau Monné freebsd_committer freebsd_triage 2020-09-23 13:38:38 UTC 
(In reply to Dima Panov from comment #4)
Thanks for the explanation, please got ahead and commit it.
Comment 6 commit-hook freebsd_committer freebsd_triage 2020-09-23 15:07:41 UTC 
A commit references this bug:

Author: fluffy
Date: Wed Sep 23 15:06:46 UTC 2020
New revision: 549738
URL: https://svnweb.freebsd.org/changeset/ports/549738

Log:
  sysutils/xen-tools: unbreak packaging

  Unbreak package with python!=3.7
  Switch to use py3.6+ only
  Use BINARY_ALIAS for python3
  Bump PORTREVISION

  PR:		249541
  Submitted by:	fluffy
  Approved by:	maintainer (royger)

Changes:
  head/sysutils/xen-tools/Makefile
  head/sysutils/xen-tools/pkg-plist