249904 – security/snort2pfcd: Update to 3.2

Bug 249904 - security/snort2pfcd: Update to 3.2

Summary: security/snort2pfcd: Update to 3.2

Status:	Closed FIXED

Alias:	None

Product:	Ports & Packages
Classification:	Unclassified
Component:	Individual Port(s) (show other bugs)
Version:	Latest
Hardware:	Any Any

Importance:	--- Affects Only Me
Assignee:	Rainer Hurling

URL:
Keywords:	buildisok

Depends on:
Blocks:

Reported:	2020-09-26 04:36 UTC by Samee Shahzada
Modified:	2020-10-04 17:13 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
Update patch (902 bytes, patch) 2020-09-26 04:37 UTC, Samee Shahzada	onestsam: maintainer-approval+	Details \| Diff
Update patch (902 bytes, patch) 2020-09-27 17:00 UTC, Samee Shahzada	onestsam: maintainer-approval+	Details \| Diff
Update patch (902 bytes, patch) 2020-09-29 07:35 UTC, Samee Shahzada	onestsam: maintainer-approval+	Details \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Samee Shahzada 2020-09-26 04:36:43 UTC

Comment 1 Samee Shahzada 2020-09-26 04:37:17 UTC

Created attachment 218308 [details]
Update patch

Comment 2 Automation User 2020-09-26 05:03:01 UTC

Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/194772397

Comment 3 Samee Shahzada 2020-09-27 17:00:58 UTC

Created attachment 218364 [details]
Update patch

Squeezing more into 3.2

Comment 4 Samee Shahzada 2020-09-29 07:35:57 UTC

Created attachment 218398 [details]
Update patch

squeezing even more bugfixes into 3.2

Comment 5 Fernando Apesteguía freebsd_committer

2020-09-30 06:25:36 UTC

^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.


Thanks!

Comment 6 Samee Shahzada 2020-09-30 23:51:26 UTC

What URL field?

Do I do
URL=www.blahblah.com/changelog
in the makefile or something?

I never started a changelog because I originally didn't expect to be developing this for so long.

The major changes for this release are optimizations:
-Moved several global variables to local
-Fewer Malloc calls
-Several stack optimizations
-More compiler flags and fixes for those warnings

-fixed a compiler escaping bug involving memset for char which may have even been preventing the program from working correctly.

memset((char*)&blah, 0, BUFSIZ); --> memset((char*)&blah, 0, (sizeof(char)*BUFSIZ)); 

I believe this bug has been present since version 1

Comment 7 Fernando Apesteguía freebsd_committer

2020-10-01 05:22:42 UTC

(In reply to Samee Shahzada from comment #6)

Hi Samee,

I mean the URL field in the PR, between the "Assignee" and "Keywords" field.

If it is a ChangeLog somewhere upstream, it would be good to have it there, but it is OK if there is not. Some projects just don't have one.

Thanks for having a look at it anyway :)

Comment 8 commit-hook freebsd_committer

2020-10-04 17:12:31 UTC

A commit references this bug:

Author: rhurlin
Date: Sun Oct  4 17:11:40 UTC 2020
New revision: 551435
URL: https://svnweb.freebsd.org/changeset/ports/551435

Log:
  security/snort2pfcd: Update to 3.2

  No official changelog available. According to maintainer, the major changes for this release are optimizations:

  -Moved several global variables to local
  -Fewer Malloc calls
  -Several stack optimizations
  -More compiler flags and fixes for those warnings
  -Fixed compiler escaping bug involving memset for char

  PR:		249904
  Submitted by:	Samee Shahzada <onestsam@gmail.com> (maintainer)
  Approved by:	tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D26659

Changes:
  head/security/snort2pfcd/Makefile
  head/security/snort2pfcd/distinfo

Comment 9 Rainer Hurling freebsd_committer

2020-10-04 17:13:29 UTC

Committed, thanks :)