Bug 250191 - textproc/libcrm114: fix build with -fno-common and deprecate port
Summary: textproc/libcrm114: fix build with -fno-common and deprecate port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2020-10-07 22:27 UTC by Martin Schütte
Modified: 2020-10-08 11:53 UTC (History)
1 user (show)

See Also:

Attachments
fix -fno-common build of libcrm114 and deprecate (5.29 KB, patch)
2020-10-07 22:27 UTC, Martin Schütte 		info: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Schütte 2020-10-07 22:27:50 UTC 
Created attachment 218603 [details]
fix -fno-common build of libcrm114 and deprecate

This patch fixes the current build errors due to the -fno-common compile option.

I also suggest to mark the port as deprecated, because its upstream is abandoned since 2010 and I am not aware of any users.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2020-10-08 06:34:08 UTC 
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]

Thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-10-08 11:53:06 UTC 
A commit references this bug:

Author: fernape
Date: Thu Oct  8 11:52:09 UTC 2020
New revision: 551701
URL: https://svnweb.freebsd.org/changeset/ports/551701

Log:
  textproc/libcrm114: fix build with -fno-common and deprecate port

  Upstream has been abandoned since 2010 and there are no consumers in the ports
  collection.

  Maintainer is not aware of any users either.

  PR:	250191
  Submitted by:	info@mschuette.name (maintainer)

Changes:
  head/textproc/libcrm114/Makefile
  head/textproc/libcrm114/files/patch-clang-fno-common
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2020-10-08 11:53:30 UTC 
Committed,

Thanks!